FIX: Describe NotImplementedErrors or use AbstractMethodError #9887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This issue fixes pandas-dev#7872 by either describing the reason why a NotImplementedError is raised, or by throwing an AbstractMethodError in the case of abstract methods (eg: Mixins) that should be overwritten by the inheriting classes. This issue is based on discussion of PR pandas-dev#7899 which was never merged.
cpcloud added Enhancement Error Reporting 
Contributor
| merged via 8fe1cf6 thanks! |
Contributor
| +1 great!! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This issue fixes #7872 by either describing the reason why a NotImplementedError is raised,
or by throwing an AbstractMethodError in the case of abstract methods (eg: Mixins) that
should be overwritten by the inheriting classes.
This issue is based on discussion of PR #7899 which was never merged.