[ink_e2e] improve call API, remove build_message + callback#1782
Merged
[ink_e2e] improve call API, remove build_message + callback#1782
[ink_e2e] improve call API, remove build_message + callback#1782Conversation
This reverts commit e733996.
cmichi approved these changes May 19, 2023
Collaborator
cmichi left a comment
There was a problem hiding this comment.
Thanks for doing this!
We should reflect the change in a CHANGELOG.md. Since we so far always released in lockstep with the rest of ink!, I would just add it there for now.
Codecov Report
@@ Coverage Diff @@ ## master #1782 +/- ## ========================================== - Coverage 52.09% 52.05% -0.05% ========================================== Files 207 207 Lines 6653 6653 ========================================== - Hits 3466 3463 -3 - Misses 3187 3190 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resurrecting the idea from #1669.
I believe it closes #1644, since the main thing is removing that ugly callback. This may not be the fina or most sophisticatedl API, but an increment in the right direction for better quality of life for
e2etest devs.Replaces
build_messageand callback with a simpler: