correct StatisticService and its methods

Author: pashaapsky

app/Http/Controllers/StaticPagesController.php

@@ -2,7 +2,7 @@
 
 namespace App\Http\Controllers;
 
-use App\Services\GetStatisticService;
+use App\Services\StatisticService;
 
 class StaticPagesController extends Controller
 {
@@ -16,28 +16,30 @@ public function aboutIndex() {
 
  public function statisticsIndex() {
  //Общее количество статей
- $postsCount = GetStatisticService::getPostsCount();
+ $statisticService = new StatisticService();
+
+ $postsCount = $statisticService->getPostsCount();
 
  //Общее количество новостей
- $newsCount = GetStatisticService::getNewsCount();
+ $newsCount = $statisticService->getNewsCount();
 
  //ФИО автора, у которого больше всего статей на сайте
- $usersWithMostPosts = GetStatisticService::getUserWithMaxPosts();
+ $usersWithMostPosts = $statisticService->getUserWithMaxPosts();
 
  //Самая длинная статья - название, ссылка на статью и длина статьи в символах
- $theLongestPost = GetStatisticService::getTheLongestPosts();
+ $theLongestPost = $statisticService->getTheLongestPosts();
 
  //Самая короткая статья - название, ссылка на статью и длина статьи в символах
- $theShortestPost = GetStatisticService::getTheShortestPosts();
+ $theShortestPost = $statisticService->getTheShortestPosts();
 
  //Средние количество статей у “активных” пользователей, при этом активным пользователь считается, если у него есть более 1-й статьи
- $avgPostsHaveActiveUsers = GetStatisticService::getAveragePosts();
+ $avgPostsHaveActiveUsers = $statisticService->getAveragePosts();
 
  //Самая непостоянная - название, ссылка на статью, которую меняли больше всего раз
- $mostChangingPosts = GetStatisticService::getMostChangingPosts();
+ $mostChangingPosts = $statisticService->getMostChangingPosts();
 
  //Самая обсуждаемая статья - название, ссылка на статью, у которой больше всего комментариев.
- $mostCommentPosts = GetStatisticService::getMostCommentPosts();
+ $mostCommentPosts = $statisticService->getMostCommentPosts();
 
  $statistics = [
  'posts_count' => $postsCount,

app/Services/GetStatisticService.php

@@ -0,0 +1,143 @@
+<?php
+
+namespace App\Services;
+
+use App\News;
+use App\Post;
+use App\User;
+use Illuminate\Database\Eloquent\Collection;
+use Illuminate\Support\Facades\DB;
+
+class StatisticService
+{
+ /**
+ * Количество постов на сайте
+ * @return int
+ */
+ public function getPostsCount()
+ {
+ return Post::count();
+ }
+
+ /**
+ * Общее количество новостей
+ * @return int
+ */
+ public function getNewsCount()
+ {
+ return News::count();
+ }
+
+
+ /**
+ * @return Collection
+ */
+
+ public function getUserWithMaxPosts()
+ {
+// $users = User::has('posts')->withCount('posts')->get();
+// $usersWithMostPostsCount = $users->where('posts_count', $users->max('posts_count'));
+
+ $users = DB::table('users')
+ ->join('posts', 'users.id', '=', 'owner_id')
+ ->select('users.name', DB::raw('Count(*) as posts_count'))
+ ->groupBy('users.name')
+ ->orderByDesc('posts_count')
+ ->first();
+
+ $usersWithMostPostsCount = User::where('name', $users->name)->withCount('posts')->get();
+
+ return $usersWithMostPostsCount;
+ }
+
+
+ /**
+ * @return Collection
+ */
+
+ public function getTheLongestPosts()
+ {
+ $theLongestPosts = Post::where(DB::raw('Length(text)'), function($query){
+ $query->select(DB::raw('MAX(Length(text))'))
+ ->from(DB::table('posts'));
+ })->get();
+
+ return $theLongestPosts;
+ }
+
+ /**
+ * @return Collection
+ */
+
+ public function getTheShortestPosts()
+ {
+ $theShortestPosts = Post::where(DB::raw('Length(text)'), function($query){
+ $query->select(DB::raw('MIN(Length(text))'))
+ ->from(DB::table('posts'));
+ })->get();
+
+ return $theShortestPosts;
+ }
+
+ /**
+ * @return int
+ */
+
+ public function getAveragePosts()
+ {
+// $posts = User::has('posts', '>', 1)->withCount('posts')->get();
+// $averagePosts = intval(round($posts->avg('posts_count')));
+
+ $averagePosts = DB::select('select AVG(u.posts_count) as avg_posts_count from (select users.*, (select Count(*) from posts where users.id = posts.owner_id) as posts_count from users) as u')[0];
+
+ $averagePosts = intval(round($averagePosts->avg_posts_count));
+
+ return $averagePosts;
+ }
+
+ /**
+ * @return Collection
+ */
+ public function getMostChangingPosts()
+ {
+// $posts = Post::has('history', '>=', 1)->withCount('history')->get();
+// $maxChangingPosts = $posts->where('history_count', $posts->max('history_count'));
+
+ $maxHistoryCount = DB::table('posts')
+ ->join('histories as h', 'posts.id', '=', 'h.post_id')
+ ->select('posts.name', DB::raw('Count(*) as history_count'))
+ ->groupBy('posts.name')
+ ->orderByDesc('history_count')
+ ->first()
+ ;
+
+ $maxChangingPosts = Post::where('name', $maxHistoryCount->name)->withCount('history')->get();
+
+ return $maxChangingPosts;
+ }
+
+ /**
+ * @return Collection
+ */
+
+ public function getMostCommentPosts()
+ {
+// $posts = Post::has('comments', '>=', 1)->withCount('comments')->get();
+// $mostCommentPosts = $posts->where('comments_count', $posts->max('comments_count'));
+
+ $maxComment = DB::table('posts')
+ ->join('comments as c', function ($join) {
+ $join->on('posts.id', '=', 'c.commentable_id')
+ ->where('c.commentable_type', '=', 'App\Post');
+ })
+ ->select('posts.name', DB::raw('Count(*) as comments_count'))
+ ->groupBy('posts.name')
+ ->orderByDesc('comments_count')
+ ->first()
+ ;
+
+ $mostCommentPosts = Post::where('name', $maxComment->name)->withCount('comments')->get();
+
+ return $mostCommentPosts;
+ }
+}

app/Services/StatisticService.php

@@ -7,7 +7,7 @@
 
 Route::get('/test', function () {
 
-});
+ });
 
 Route::get('/', function () {
  $posts = Post::with('tags')->where('published', 1)->latest()->take(4)->get();