Function with yield from wasn't recognized as generator

Author: ondrejmirtes

composer.json

@@ -21,7 +21,7 @@
 "nette/utils": "^3.1.1",
 "nikic/php-parser": "^4.5.0",
 "ondram/ci-detector": "^3.1",
-"ondrejmirtes/better-reflection": "^4.3.2",
+"ondrejmirtes/better-reflection": "^4.3.3",
 "phpdocumentor/type-resolver": "1.0.1",
 "phpstan/phpdoc-parser": "^0.4.7",
 "react/child-process": "^0.6.1",

tests/PHPStan/Rules/Functions/ReturnTypeRuleTest.php

@@ -70,4 +70,13 @@ public function testReturnTypeRulePhp70(): void
 ]);
 }
 
+public function testIsGenerator(): void
+{
+if (!self::$useStaticReflectionProvider) {
+$this->markTestSkipped('Test requires static reflection.');
+}
+
+$this->analyse([__DIR__ . '/data/is-generator.php'], []);
+}
+
 }

tests/PHPStan/Rules/Functions/data/is-generator.php

@@ -0,0 +1,28 @@
+<?php
+
+namespace FunctionGeneratorReturn;
+
+class Foo
+{
+
+}
+
+if (false) {
+function doBar(bool $skipThings): iterable
+{
+if ($skipThings) {
+return;
+}
+
+yield 1;
+}
+
+function doFoo(bool $skipThings): iterable
+{
+if ($skipThings) {
+return;
+}
+
+yield from array();
+}
+}