No removal of close event handlers on server reconnect, emits reconnect event when reconnection happens. Reconnect Only applies for single server connections as of now as semantics for ReplSet and Mongos is not clear (Issue #1056)

Author: christkv

HISTORY

@@ -1,6 +1,8 @@
 1.3.19 2013-08-21
 -----------------
 - Correctly rethrowing errors after change from event emission to callbacks, compatibility with 0.10.X domains without breaking 0.8.X support.
+- Small fix to return the entire findAndModify result as the third parameter (Issue #1068)
+- No removal of "close" event handlers on server reconnect, emits "reconnect" event when reconnection happens. Reconnect Only applies for single server connections as of now as semantics for ReplSet and Mongos is not clear (Issue #1056)
 
 1.3.18 2013-08-10
 -----------------

lib/mongodb/connection/base.js

@@ -195,26 +195,13 @@ DbStore.prototype.fetch = function(databaseName) {
 DbStore.prototype.emit = function(event, message, object, reset, filterDb, rethrow_if_no_listeners) {
  var emitted = false;
 
- if(reset) {
- while(this._dbs.length > 0) {
- var db = this._dbs.shift();
- // Only emit if there is a listener
- if(db.listeners(event).length > 0) {
- if(filterDb == null || filterDb.databaseName !== db.databaseName 
- || filterDb.tag !== db.tag) {
- db.emit(event, message, object == null ? db : object);
- emitted = true;
- }
- }
- }
- } else {
- for(var i = 0; i < this._dbs.length; i++) {
- if(this._dbs[i].listeners(event).length > 0) {
- if(filterDb == null || filterDb.databaseName !== this._dbs[i].databaseName 
- || filterDb.tag !== this._dbs[i].tag) {
- this._dbs[i].emit(event, message, object == null ? this._dbs[i] : object);
- emitted = true;
- }
+ // Emit the events
+ for(var i = 0; i < this._dbs.length; i++) {
+ if(this._dbs[i].listeners(event).length > 0) {
+ if(filterDb == null || filterDb.databaseName !== this._dbs[i].databaseName 
+ || filterDb.tag !== this._dbs[i].tag) {
+ this._dbs[i].emit(event, message, object == null ? this._dbs[i] : object);
+ emitted = true;
  }
  }
  }

lib/mongodb/connection/server.js

@@ -368,8 +368,12 @@ Server.prototype.connect = function(dbInstance, options, callback) {
  // Save document returned so we can query it
  _server.isMasterDoc = reply.documents[0];
 
- if(self.emitOpen)
+ if(self.emitOpen) { 
  _server._emitAcrossAllDbInstances(_server, eventReceiver, "open", null, returnIsMasterResults ? reply : null, null); 
+ self.emitOpen = false;
+ } else {
+ _server._emitAcrossAllDbInstances(_server, eventReceiver, "reconnect", null, returnIsMasterResults ? reply : null, null); 
+ }
 
  // If we have it set to returnIsMasterResults
  if(returnIsMasterResults) {