removing Expression from the AST tree #1294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
fvictorio approved these changes Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is one of the biggest changes in the process of removing
PolymorphicNodes from the tree.Expressions are used over all the AST tree therefore there's already a vast amount of files that needed to change.Also the queries for the
grandparentnode were designed this way because we would navigate through anExpression. By removing theExpressionall of these queries needed to be redesigned to aparentquery. In this case there are some for loops that where increasing the index by 2 to skip theExpression, now they increase by 1.createHugFunctionnow has to create a smaller tree when adding parentheses because there is no need forExpressionnow.