Skip to content

Fix failure in time encoding for pandas < 0.21.1 #2630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 24, 2018
Merged

Fix failure in time encoding for pandas < 0.21.1 #2630

merged 3 commits into from
Dec 24, 2018

Conversation

@spencerkclark
Copy link
Member

@spencerkclark spencerkclark commented Dec 24, 2018 •
edited
Loading

This is related to a bug fixed in pandas-dev/pandas#18020 (comment) (this should return a TimedeltaIndex):

In [2]: times = pd.date_range('2000', periods=3) In [3]: times - np.datetime64('2000-01-01') Out[3]: DatetimeIndex(['1970-01-01', '1970-01-02', '1970-01-03'], dtype='datetime64[ns]', freq='D')

Subtracting a Timestamp object seems to work in all versions:

In [4]: times - pd.Timestamp('2000-01-01') Out[4]: TimedeltaIndex(['0 days', '1 days', '2 days'], dtype='timedelta64[ns]', freq=None)
@shoyer shoyer merged commit 7fcb80f into pydata:master Dec 24, 2018
@shoyer
Copy link
Member

shoyer commented Dec 24, 2018

Thanks!
dcherian pushed a commit to yohai/xarray that referenced this pull request Jan 2, 2019
Merge branch 'master' into yohai-ds_scatter
faf4302 
* master: DEP: drop python 2 support and associated ci mods (pydata#2637) TST: silence warnings from bottleneck (pydata#2638) revert to dev version DOC: fix docstrings and doc build for 0.11.1 Source encoding always set when opening datasets (pydata#2626) Add flake check to travis (pydata#2632) Fix dayofweek and dayofyear attributes from dates generated by cftime_range (pydata#2633) silence import warning (pydata#2635) fill_value in shift (pydata#2470) Flake fixed (pydata#2629) Allow passing of positional arguments in `apply` for Groupby objects (pydata#2413) Fix failure in time encoding for pandas < 0.21.1 (pydata#2630) Fix multiindex selection (pydata#2621) Close files when CachingFileManager is garbage collected (pydata#2595) added some logic to deal with rasterio objects in addition to filepaths (pydata#2589) Get 0d slices of ndarrays directly from indexing (pydata#2625) FIX Don't raise a deprecation warning for xarray.ufuncs.{angle,iscomplex} (pydata#2615) CF: also decode time bounds when available (pydata#2571)
@matteodefelice matteodefelice mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@spencerkclark @shoyer