Skip to content

Commit 2683834

Browse files
rokmbwoodsend
authored andcommitted
ci: move work-around for potentially broken setuptools upgrade
Move the "Work around potentially broken setuptools upgrade" step upgrade after the "Install test dependencies (tools and libraries)" step, which is now the step that installs/upgrades `setuptools`.
1 parent 383196a commit 2683834

File tree

1 file changed

+30
-30
lines changed

1 file changed

+30
-30
lines changed

.github/workflows/ci.yml

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,36 @@ jobs:
143143
- name: Update pip
144144
run: python -m pip install --upgrade pip hatchling
145145

146-
# On (macos-14, python 3.10), (macos-13, python 3.11) and (macos-14, python 3.11)
146+
- name: Compile bootloader
147+
run: cd bootloader && python waf --tests all
148+
149+
- name: Download dependencies
150+
shell: bash
151+
run: python -m pip download --dest=dist .[completion] && rm -f dist/pyinstaller-*.whl
152+
153+
- name: Build wheels
154+
run: sh release/build-wheels
155+
156+
- name: Install PyInstaller
157+
run: python -m pip install --no-index --find-links=dist pyinstaller[completion]
158+
159+
- name: Check pyinstaller --help
160+
run: python -m PyInstaller -h
161+
162+
- name: Install test dependencies (base tools)
163+
run: |
164+
python -m pip install --progress-bar=off --upgrade --requirement tests/requirements-base.txt
165+
166+
# Give python 3.13t same treatment as development version and avoid trying to install packges
167+
# from requirements-libraries.txt. This is necessary because not all packages provide free-threaded
168+
# builds of their wheels yet, and we have no way of filtering them in the requirements file.
169+
# This should be remedied in python 3.14 with the new `sys_abi_feature` environment marker (PEP 780).
170+
- name: Install test dependencies (tools and libraries)
171+
if: ${{ !endsWith(matrix.python-version, '-dev') && matrix.python-version != '3.13t' }}
172+
run: |
173+
python -m pip install --progress-bar=off --upgrade --requirement tests/requirements-libraries.txt
174+
175+
# On (macos-14, python 3.10), (macos-13, python 3.11) and (macos-14, python 3.11)
147176
# combinations the initial `setuptools` installation seems to contain `.opt-1.pyc`
148177
# files in `__pycache__` directories. During the upgrade, `pip` fails to remove
149178
# those directories (https://github.com/pypa/pip/issues/11835).
@@ -190,35 +219,6 @@ jobs:
190219
print(f"Removing {path}...")
191220
shutil.rmtree(path)
192221
193-
- name: Compile bootloader
194-
run: cd bootloader && python waf --tests all
195-
196-
- name: Download dependencies
197-
shell: bash
198-
run: python -m pip download --dest=dist .[completion] && rm -f dist/pyinstaller-*.whl
199-
200-
- name: Build wheels
201-
run: sh release/build-wheels
202-
203-
- name: Install PyInstaller
204-
run: python -m pip install --no-index --find-links=dist pyinstaller[completion]
205-
206-
- name: Check pyinstaller --help
207-
run: python -m PyInstaller -h
208-
209-
- name: Install test dependencies (base tools)
210-
run: |
211-
python -m pip install --progress-bar=off --upgrade --requirement tests/requirements-base.txt
212-
213-
# Give python 3.13t same treatment as development version and avoid trying to install packges
214-
# from requirements-libraries.txt. This is necessary because not all packages provide free-threaded
215-
# builds of their wheels yet, and we have no way of filtering them in the requirements file.
216-
# This should be remedied in python 3.14 with the new `sys_abi_feature` environment marker (PEP 780).
217-
- name: Install test dependencies (tools and libraries)
218-
if: ${{ !endsWith(matrix.python-version, '-dev') && matrix.python-version != '3.13t' }}
219-
run: |
220-
python -m pip install --progress-bar=off --upgrade --requirement tests/requirements-libraries.txt
221-
222222
- name: Start display server
223223
if: startsWith(matrix.os, 'ubuntu')
224224
run: |

0 commit comments

Comments
 (0)