Downstreaming Aesara PR 1346: "Add JAX implementation for LogNormalRV" #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ricardoV94 approved these changes Dec 11, 2022
Member
ricardoV94 left a comment
ricardoV94 left a comment There was a problem hiding this comment.
In the future we could also just rewrite these into the subset of RVs that have implementation in JAX. LogNormal -> Exp(Normal)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
@@ Coverage Diff @@ ## main #106 +/- ## ======================================= Coverage 74.40% 74.41% ======================================= Files 179 179 Lines 49226 49236 +10 Branches 10420 10420 ======================================= + Hits 36627 36637 +10 Misses 10294 10294 Partials 2305 2305
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Downstreaming aesara-devs/aesara#1346. PR port done by downstream_pr.sh script.