Fix solve_triangular output when overwrite_b=True #1235
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Issue #1233 found a bug in the numba mode of
solve_triangular. Basically, we can't get around copying the incoming matrices if they're not already F-contiguous. Also adds a regression test for this bug.Related Issue
solve_triangularreturns wrong results whenoverwrite_b=True#1233Checklist
Type of change
📚 Documentation preview 📚: https://pytensor--1235.org.readthedocs.build/en/1235/