Handle mixed input dtypes and empty size in numba lapack functions #1764
+385 −268
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Still WIP, spinoff from #811
Major changes:
view(inp).ctypes -> inp.ctypesRe: Change
view(inp).ctypes -> inp.ctypesThis may have be needed when working with complex inputs? But we are not supporting them in most implementations, so it makes code more complex and is a potential source of bugs when we fail to systematically upcast input (point 3. from above)
Say we have a float32 and a float64 inputs, and forget to upcast the first one. Calling
viewwill raise for non f-contiguous inputs (which we always need for these routines):Even if it didn't raise the meaning of the array would be nonsensical:
I think we need to call different routines for complex inputs anyway?