Skip to content

Conversation

@michaelosthege
Copy link
Member

@michaelosthege michaelosthege commented Nov 20, 2022

This PR renames the project as decided internally.

Rename related changes

  • Aesara → Pytensor
  • aesara → pytensor
  • AESARA → PYTENSOR
  • Applied pre-commit
  • GitHub repository URL
  • Contact email addresses → pymc.devs@gmail.com

Further changes

  • Upgraded mypy and fixed a platform-specific mypy error
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@michaelosthege michaelosthege force-pushed the rename branch 6 times, most recently from 82013be to 633028e Compare November 20, 2022 13:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@5aa1780). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@ ## main #2 +/- ## ======================================= Coverage ? 74.10% ======================================= Files ? 174 Lines ? 48681 Branches ? 10379 ======================================= Hits ? 36074 Misses ? 10313 Partials ? 2294 
Changes * Aesara → Pytensor * aesara → pytensor * AESARA → PYTENSOR * Applied pre-commit * GitHub repository URLs * Contact email addresses * Headline length in RST files
@ricardoV94
Copy link
Member

When should we change the aliases? import pytensor.tensor as pt

@michaelosthege
Copy link
Member Author

michaelosthege commented Nov 20, 2022

When should we change the aliases? import pytensor.tensor as pt

I would either not do it already (to keep pulling upstream easier) or do it in a follow-up PR.

Getting this rename merged early means that we can start splitting up tasks about Readme, Logo, CoC, deployment and other things

@michaelosthege michaelosthege merged commit 19e1a98 into main Nov 21, 2022
@michaelosthege michaelosthege deleted the rename branch November 21, 2022 08:56
@twiecki
Copy link
Member

twiecki commented Nov 23, 2022

@michaelosthege Do you have the code you used for this?

@michaelosthege
Copy link
Member Author

michaelosthege commented Nov 23, 2022

Ctrl+Shift+H in VS Code, then search "Aesara" with case-sensitivity, replace by "PyTensor"...

I did this manually for the three bullet points in the description, then searched again for pytensor-devs and pytensor.devs to find the URLs and Email addresses and fixed those manually.

Oh and then I searched the file explorer in VS Code to find file names containing aesara. Of those there were a couple in c_code and a Jupyter notebook IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants