Skip to content

Fuse ca reduce and elemwise #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Fuse ca reduce and elemwise #25

wants to merge 14 commits into from

Conversation

@twiecki
Copy link
Member

@twiecki twiecki commented Nov 23, 2022

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.
brandonwillard and others added 14 commits November 20, 2022 14:44
@brandonwillard
Remove unnecessary graph_inputs usage in OpFromGraph
7130281
@brandonwillard
Remove redundant cloning when swapping nominal variables in OpFromGraph
5044067
@brandonwillard
Generalize the inner-FunctionGraph construction process
14c394d
@brandonwillard
Make SharedVariable.default_update a persistent property
3111daf 
`Type` checks are also performed when values are assigned to the property.
@brandonwillard
Clean up docstrings and errors relating to SharedVariable
b492f05
@brandonwillard
Use singledispatch to register SharedVariable type constructors
bae26ef
@brandonwillard
Refactor SharedVariable type and interface
3ad936f
@brandonwillard
Remove unnecessary logger and dunder setting in pfunc
ef48c31
@brandonwillard
Merge CAReduce and CAReduceDtype
fff1295
@brandonwillard
Refactor Composite Op
7cf298c 
- Lazily create and cache `FunctionGraph`s, the `Composite.perform` implementation, C code, and name values - Use `fgraph_to_python` for `Composite.perform` - Use the `HasInnerGraph` interface
@brandonwillard
Add get_target_language function and remove tests.compile.test_modes
c8c4970
@brandonwillard
Set the global mode during compilation
3506c5e
@brandonwillard
Add a fusion rewrite for CAReduces with Elemwise inputs
f1751d8
@twiecki
Remove -e files.
87ec6da
@twiecki twiecki closed this Nov 23, 2022
@twiecki twiecki deleted the fuse-CAReduce-and-Elemwise branch November 23, 2022 15:55
@ricardoV94 ricardoV94 added the aesara downstream PRs that were downstreamed from Aesara label Dec 13, 2022
@ricardoV94 ricardoV94 mentioned this pull request Jun 30, 2023
Merged
@brendan-m-murphy brendan-m-murphy mentioned this pull request Aug 7, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aesara downstream PRs that were downstreamed from Aesara

3 participants

@twiecki @ricardoV94 @brandonwillard