Skip to content

Conversation

@ricardoV94
Copy link
Member

@ricardoV94 ricardoV94 commented May 3, 2024

Description

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):
@codecov
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.82%. Comparing base (b8e26cd) to head (b6ac1d9).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@ ## main #744 +/- ## ========================================== + Coverage 80.81% 80.82% +0.01%  ========================================== Files 162 162 Lines 46808 46851 +43 Branches 11452 11464 +12 ========================================== + Hits 37826 37867 +41  - Misses 6734 6735 +1  - Partials 2248 2249 +1 
Files Coverage Δ
pytensor/tensor/basic.py 88.36% <100.00%> (+0.11%) ⬆️
pytensor/tensor/subtensor.py 89.87% <100.00%> (+0.19%) ⬆️

... and 2 files with indirect coverage changes

@ricardoV94 ricardoV94 requested a review from lucianopaz May 7, 2024 15:57
@ricardoV94 ricardoV94 added the enhancement New feature or request label May 7, 2024
@ricardoV94 ricardoV94 marked this pull request as ready for review May 7, 2024 15:57
Copy link
Member

@lucianopaz lucianopaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardoV94, the vectorize on join seems fine to me but I had a couple of questions about the AdvancedSubtensor part. Once you answer those, I think that you should be good to merge.

)

@staticmethod
def non_contiguous_adv_indexing(node: Apply) -> bool:
Copy link
Member Author

@ricardoV94 ricardoV94 May 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this as a staticmethod of the Op because I know we'll need to check for this case in many of the lifting rewrites, and it's nice to access it once we have a handle for the Op

@lucianopaz lucianopaz merged commit 82a5757 into pymc-devs:main May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request vectorization

2 participants