[BUG] Fix accumulating flags after compile/link #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jaraco force-pushed the main branch 3 times, most recently from 12769e5 to d23e28a Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is a more complete fix for the issue reported in pypa/setuptools#3591 and partially addressed in #199.
The fix for
library_dirs = self.library_dirsis essential, otherwise the compiler instance keeps accumulating flags after each linking invocation.The other fixes are a matter of good practice (don't return mutable internal state) and consistency (otherwise mutable internal state is returned for some stuff and not for other).