Skip to content

Conversation

@JGoutin
Copy link
Contributor

@JGoutin JGoutin commented Jun 12, 2018

Summary of changes

Fix Microsoft Visual C++ Build Tools dead link.

Closes #1394

Pull Request Checklist

  • Changes have tests: Only change link in string.
  • News fragment added in changelog.d. See documentation for details
@pganssle
Copy link
Member

According to @zooba in #1394:

The current best URL is https://visualstudio.microsoft.com/downloads/ and the title is "Build Tools for Visual Studio"

Given that Steve works for Microsoft I believe him - plus his link is https.

@pganssle
Copy link
Member

I'm tempted to add a # pragma: nocover comment to the version switch, but I think it doesn't really make sense to do so, so we can just merge even with 0% diff coverage for now.

@JGoutin
Copy link
Contributor Author

JGoutin commented Jun 29, 2018

The link I set in PR is in fact a redirection to the like you quoted. It look to work also in HTTPS. So I replaced the link.

Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a minor change adding a colon to be consistent with the other errors, otherwise LGTM.

@JGoutin
Copy link
Contributor Author

JGoutin commented Jun 29, 2018

Normalized formatting.

@pganssle pganssle merged commit e50d77e into pypa:master Jul 10, 2018
@JGoutin JGoutin deleted the issue-buildtooldeadlink branch September 26, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants