Custom Deprecation Warning classes. #1545
Conversation
robinjhuang changed the title 
| Added unit tests, so the previous code coverage issue should be resolved now. Let us know if you want anything else changed :) @martonp and I are interested in Python events in New York. Please let us know about future events. We had a lot of fun at this hackathon. Our emails: |
CHANGES.rst Outdated
| v40.5.0 | ||
| ------- | ||
| | ||
| * #1545: Added custom deprecation warning classes because DeprecationWarning is not visible unless the user opts in. |
There was a problem hiding this comment.
There's a better way to add changelog entries. Please see these docs on how to use towncrier to author changelog entries.
There was a problem hiding this comment.
Thanks Jason. I'm a bit confused, should we be commiting the news fragment file? Or should we run towncrier to add the changes to the CHANGES.rst?
There was a problem hiding this comment.
Commit the news fragment: one of the reasons for using towncrier is to avoid merge conflicts in CHANGES.rst.
There was a problem hiding this comment.
Ohhhh I see. Let me change that. Thank you!
robinjhuang force-pushed the custom-deprecation-warnings branch from 71abc91 to 67124b3 Compare 
pganssle force-pushed the custom-deprecation-warnings branch 4 times, most recently from 5c795d0 to d3b9c97 Compare 
`DeprecationWarning` is not visible by default in the latest versions of CPython, so this switches the deprecation warnings in setuptools and pkg_resources over to custom classes derived from `Warning` instead. Fixes issue github issue pypa#159 Co-authored-by: Junhan Huang <robin.j.huang@gmail.com> Co-authored-by: Marton Pono <marci93@gmail.com>
These are tests to ensure that the specified deprecation warnings are raised when the functions are called. Co-authored-by: Junhan Huang <robin.j.huang@gmail.com> Co-authored-by: Marton Pono <marci93@gmail.com>
pganssle force-pushed the custom-deprecation-warnings branch from d3b9c97 to 3a9dc2b Compare 
pganssle left a comment
pganssle left a comment There was a problem hiding this comment.
I have tweaked some of the details of this implementation and cleaned up the git commit history a bit, so it's ready to merge.
4 participants
Added custom deprecation warning classes because DeprecationWarning is not visible unless the user opts in.
Closes Issue #159