Fix missing dependencies with setup.py install #3212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Starting in v61, setuptools.dist overwrites distutils.dist.run_command to add auto-discovery functionality on top of the original implementation. This change modifies the existing code in setuptools.command.install to consider that previous change when trying to decide if the install command was called directly from `setup.py` or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary of changes
setuptools.command.installto detect whether the command was called directly fromsetup()or by another command.Closes #3198
Pull Request Checklist
changelog.d/.(See documentation for details)