Skip to content

Conversation

@joycebrum
Copy link
Contributor

@joycebrum joycebrum commented Feb 17, 2023

Summary of changes

  • Add top level permissions as contents: read
  • Add run level permission of main.yml as contents: write

I've tested both actions

ci-sage.yml

main.yml

I tried to make main.yml work but I think it is not an error related to GITHUB_TOKEN permissions since it had contents: write permission. I've concluded it was related to access to pypi and, being it, it makes total sense that the action failed. Let me know if I get it wrong or if there is any more test I can do.

Closes #3830

Pull Request Checklist

joycebrum and others added 4 commits February 16, 2023 14:10
Signed-off-by: Joyce <joycebrumu.u@gmail.com>
Signed-off-by: Joyce <joycebrum@google.com>
Signed-off-by: Joyce <joycebrum@google.com>
@abravalheri
Copy link
Contributor

Thank you very much @joycebrum, that looks good.
Let's see what is the review in jaraco/skeleton

@jaraco
Copy link
Member

jaraco commented Jun 21, 2023

After merging with main (and resolving that the conflicts that weren't caught by git), this change only applies to ci-sage.yml.

@jaraco jaraco merged commit d039e54 into pypa:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants