docs: Add a note about historical wheel use in requires #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
abravalheri reviewed Mar 19, 2023
Add a note explaining that the `wheel` requirement that used to be historically used in documentation was incorrect. This also explains why it can frequently be found in existing projects, and what problems it causes. I find myself repeatedly explaining it, so I think having a single official source would be better. Incorporates suggestions from Anderson Bravalheri.
Contributor
| Let's see if the CI pass now (there might be problems with 3.12, but I am addressing those in a different PR). |
Contributor
| Thank you very much for the contribution. |
Contributor Author
| Thanks! |
4 tasks
matthewfeickert added a commit to matthewfeickert/cvmfs-venv that referenced this pull request Jul 31, 2025
* Remove install and upgrade of wheel. - For dependencies that don't provide a wheel, and don't have build-system metadata in pyproject.toml, modern setuptools has integrated wheel and so installation is unnecessary. c.f. pypa/setuptools#3859
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary of changes
Add a note explaining that the
wheelrequirement that used to be historically used in documentation was incorrect. This also explains why it can frequently be found in existing projects, and what problems it causes. I find myself repeatedly explaining it, so I think having a single official source would be better.Pull Request Checklist
changelog.d/.(See documentation for details)