Show more info from pkg_resources deprecation #3920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
abravalheri force-pushed the pkg_resources_deprecation_help branch from ea23cff to 55e1807 Compare 
…oint to ResourceManager.resource_filename not user code)
abravalheri force-pushed the pkg_resources_deprecation_help branch from 55e1807 to 98537a9 Compare 
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary of changes
When the pkg_resources deprecation is triggered, show a link to the docs which have more information about recommended replacements.
Also set
stacklevelso that the warning cites the calling code rather than pkg_resources itself.