Skip to content

Exclude debian dir #4001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2023
Merged

Exclude debian dir #4001

merged 4 commits into from
Aug 8, 2023

Conversation

@stefanor
Copy link
Contributor

@stefanor stefanor commented Aug 5, 2023 •
edited
Loading

Summary of changes

In a Debian package build, there is going to be a top-level debian directory. Exclude this from namespace_package searches by default.

Pull Request Checklist
@stefanor
Copy link
Contributor Author

stefanor commented Aug 6, 2023

It's hard to imagine that these 3.12 test failures are related to the branch's changes
@stefanor
Copy link
Contributor Author

stefanor commented Aug 6, 2023

It's hard to imagine that these 3.12 test failures are related to the branch's changes

Yep, reproduced on main, locally.
abravalheri
abravalheri approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @stefanor.

I will have a look on main for 3.12. Maybe the latest release changed something.

I will assume that everyone maintaining python-debian is happy to specify packages = manually and opt-out on auto-discover (just documenting it here, following up the conversation on Discord). Please let me know if this assumption is not correct.
@stefanor
Copy link
Contributor Author

stefanor commented Aug 7, 2023

I will assume that everyone maintaining python-debian is happy to specify packages = manually and opt-out on auto-discover (just documenting it here, following up the conversation on Discord). Please let me know if this assumption is not correct.

Yeah, that's understood, and not an issue at all.
stefanor and others added 4 commits August 7, 2023 16:23
@stefanor @abravalheri
Exclude debian dirs from the default namespace search
5acf1bc
@stefanor @abravalheri
Exclude "debian" from top_level.txt.
f404fcc 
In the debian package build of setuptools, the "debian" directory gets discovered because it's a top-level directory in the source tree, but it isn't a module we install. Author: Stefano Rivera <stefanor@debian.org> Bug-Debian: https://bugs.debian.org/1041091
@stefanor @abravalheri
A news fragment
8bca405
@stefanor @abravalheri
Explain where we are ignoring Debian
bc13743 
Co-authored-by: Anderson Bravalheri <andersonbravalheri+github@gmail.com>
@abravalheri
Copy link
Contributor

abravalheri commented Aug 7, 2023 •
edited
Loading

(I think) I fixed the errors on main and rebased the PR.
@abravalheri abravalheri merged commit 5169a9b into pypa:main Aug 8, 2023
@stefanor stefanor deleted the exclude-debian-dir branch February 27, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@stefanor @abravalheri