gh-112088: Run autoreconf in GHA check_generated_files #112090
Conversation
vstinner force-pushed the avoid_quay_io branch from 026ed0e to 7f3e933 Compare vstinner requested review from corona10, erlend-aasland, ezio-melotti and hugovk as code owners 
gpshead left a comment
gpshead left a comment There was a problem hiding this comment.
I think this is a good idea. It doesn't appear there is any reason for the quay.io image anymore given ubuntu-22.04 has a sufficiently good autoconf.
hugovk left a comment
hugovk left a comment There was a problem hiding this comment.
Let's update https://github.com/python/cpython/blob/d4f83e1e3a19e2f881115f20d58ae6a019ddb48f/Doc/using/configure.rst#generated-files as well.
And backport?
vstinner force-pushed the avoid_quay_io branch from cc67cbd to e713876 Compare vstinner added needs backport to 3.11 | @hugovk: I completed the PR to address your review. Would you mind to review the updated PR?
Done.
I added the backport to 3.11 and 3.12 labels. |
| The main point of this PR is that |
The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the external quay.io server. Add Tools/build/regen-configure.sh script to regenerate the configure with an Ubuntu container image. The "quay.io/tiran/cpython_autoconf:271" container image (https://github.com/tiran/cpython_autoconf) is no longer used.
vstinner force-pushed the avoid_quay_io branch from 96437cb to 4f8987f Compare | Oh, there is a fix in the Changelog entry causing the Docs job to fail: fixed. |
| @erlend-aasland: It would be nice if you could review this change, since you made many configure changes last months ;-) |
| Also, the devguide must be updated. |
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
This looks good to me. (I'm a little bit puzzled by the aclocal.m4 and configure changes, but they are also fine.)
Thanks for doing this.
| IIRC, we did the autoconf version bump before the 3.12 freeze, so IMO we should backport this to 3.12. |
I'm not sure if I picked the wrong With my change, the Python workflow no longer pulls an external container image, but simply reuse what's available on Ubuntu 22.04 in the GitHub Action.
Oh. So we cannot backport this change to 3.11? |
This comment was marked as outdated.
This comment was marked as outdated.
…H-112090) The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the external quay.io server. Add Tools/build/regen-configure.sh script to regenerate the configure with an Ubuntu container image. The "quay.io/tiran/cpython_autoconf:271" container image (https://github.com/tiran/cpython_autoconf) is no longer used. (cherry picked from commit d9fd33a) Co-authored-by: Victor Stinner <vstinner@python.org>
This comment was marked as outdated.
This comment was marked as outdated.
| Merged. Thanks for reviews. Let's start with a backport to 3.12. |
No, 3.11 uses a patched Autoconf 2.69 from Alpine Linux, not a vanilla 2.69 installation. |
| For 3.11 and earlier autoconf version configure generation udpates, ask the release managers (@pablogsal and @ambv) for those branches. (it makes sense for 3.12) |
…112090) The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the external quay.io server. Add Tools/build/regen-configure.sh script to regenerate the configure with an Ubuntu container image. The "quay.io/tiran/cpython_autoconf:271" container image (https://github.com/tiran/cpython_autoconf) is no longer used. (cherry picked from commit d9fd33a)
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
) (#112159) gh-112088: Run autoreconf in GHA check_generated_files (#112090) The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the external quay.io server. Add Tools/build/regen-configure.sh script to regenerate the configure with an Ubuntu container image. The "quay.io/tiran/cpython_autoconf:271" container image (https://github.com/tiran/cpython_autoconf) is no longer used. (cherry picked from commit d9fd33a)
…112090) The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the external quay.io server. Add Tools/build/regen-configure.sh script to regenerate the configure with an Ubuntu container image. The "quay.io/tiran/cpython_autoconf:271" container image (https://github.com/tiran/cpython_autoconf) is no longer used.
…112090) The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the external quay.io server. Add Tools/build/regen-configure.sh script to regenerate the configure with an Ubuntu container image. The "quay.io/tiran/cpython_autoconf:271" container image (https://github.com/tiran/cpython_autoconf) is no longer used.
| I can see using of Should we provide some changes to docs for update them? |
Yes. Do you want to propose a PR to update the doc? |
Yes, I do. |
6 participants
The "Check if generated files are up to date" job of GitHub Actions now runs the "autoreconf -ivf -Werror" command instead of the "make regen-configure" command to avoid depending on the unstable quay.io server.