gh-83004: Harden _socket init #103261
Merged
gh-83004: Harden _socket init #103261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| See also gh-99044 for a partial hardening. |
erlend-aasland added skip news 🔨 test-with-refleak-buildbots 
| 🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 0722e40 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot removed the 🔨 test-with-refleak-buildbots 
hauntsaninja approved these changes Apr 7, 2023
Contributor
hauntsaninja left a comment
hauntsaninja left a comment There was a problem hiding this comment.
This looks good to me, thank you!
Contributor
| Status check is done, and it's a success ✅. |
warsaw pushed a commit to warsaw/cpython that referenced this pull request Apr 11, 2023
Automerge-Triggered-By: GH:erlend-aasland
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Automerge-Triggered-By: GH:erlend-aasland