Skip to content

gh-114077: Fix OverflowError in socket.sendfile() when pass count >2GiB #114079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

gh-114077: Fix OverflowError in socket.sendfile() when pass count >2GiB #114079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b44c4
gh-114077: Fix OverflowError in socket.sendfile() when pass count >2GiB
serhiy-storchaka Jan 15, 2024
d6871d2
Update Misc/NEWS.d/next/Library/2024-01-15-12-12-54.gh-issue-114077.K…
serhiy-storchaka Jan 16, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ def _sendfile_use_sendfile(self, file, offset=0, count=None):
if timeout and not selector_select(timeout):
raise TimeoutError('timed out')
if count:
blocksize = count - total_sent
blocksize = min(count - total_sent, blocksize)
if blocksize <= 0:
break
try:
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2024-01-15-12-12-54.gh-issue-114077.KcVnfj.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix possible :exc:`OverflowError` in :meth:`socket.socket.sendfile` when pass
*count* larger than 2 GiB on 32-bit platform.