Skip to content

Conversation

@zooba
Copy link
Member

@zooba zooba commented May 22, 2024

@zooba zooba added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 22, 2024
@zooba zooba merged commit df93f5d into python:main May 29, 2024
@miss-islington-app
Copy link

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@zooba zooba deleted the gh-119070 branch May 29, 2024 17:51
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2024
… extension (pythonGH-119426) (cherry picked from commit df93f5d) Co-authored-by: Steve Dower <steve.dower@python.org>
@miss-islington-app
Copy link

Sorry, @zooba, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker df93f5d4bf9d70036d485666d4dd4f009d37f8b9 3.12 
@bedevere-app
Copy link

bedevere-app bot commented May 29, 2024

GH-119739 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 29, 2024
zooba added a commit to zooba/cpython that referenced this pull request May 29, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 29, 2024

GH-119741 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label May 29, 2024
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows10 3.12 has failed when building commit bc01c5d.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1159/builds/1004) and take a look at the build logs.
  4. Check if the failure is related to this commit (bc01c5d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1159/builds/1004

Failed tests:

  • test_launcher

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last): File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\single.py", line 181, in _runtest_env_changed_exc _load_run_test(result, runtests) File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\single.py", line 138, in _load_run_test regrtest_runner(result, test_func, runtests) File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\single.py", line 91, in regrtest_runner test_result = test_func() ^^^^^^^^^^^ File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\single.py", line 135, in test_func return run_unittest(test_mod) ^^^^^^^^^^^^^^^^^^^^^^ File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\single.py", line 37, in run_unittest return _run_suite(tests) ^^^^^^^^^^^^^^^^^ File "D:\buildarea\3.12.bolen-windows10\build\Lib\test\libregrtest\single.py", line 57, in _run_suite result = runner.run(suite) ^^^^^^^^^^^^^^^^^ File "D:\buildarea\3.12.bolen-windows10\build\Lib\unittest\runner.py", line 240, in run test(result) File "D:\buildarea\3.12.bolen-windows10\build\Lib\unittest\suite.py", line 84, in __call__ return self.run(*args, **kwds) ^^^^^^^^^^^^^^^^^^^^^^^ File "D:\buildarea\3.12.bolen-windows10\build\Lib\unittest\suite.py", line 122, in run test(result) File "D:\buildarea\3.12.bolen-windows10\build\Lib\unittest\suite.py", line 84, in __call__ return self.run(*args, **kwds) ^^^^^^^^^^^^^^^^^^^^^^^ File "D:\buildarea\3.12.bolen-windows10\build\Lib\unittest\suite.py", line 122, in run test(result) File "D:\buildarea\3.12.bolen-windows10\build\Lib\unittest\case.py", line 690, in __call__ return self.run(*args, **kwds) ^^^^^^^^^^^^^^^^^^^^^^^ File "D:\buildarea\3.12.bolen-windows10\build\Lib\unittest\case.py", line 660, in run result.stopTest(self) File "D:\buildarea\3.12.bolen-windows10\build\Lib\unittest\result.py", line 81, in stopTest self._restoreStdout() File "D:\buildarea\3.12.bolen-windows10\build\Lib\unittest\result.py", line 92, in _restoreStdout self._original_stdout.write(STDOUT_LINE % output) File "D:\buildarea\3.12.bolen-windows10\build\Lib\encodings\cp1252.py", line 19, in encode return codecs.charmap_encode(input,self.errors,encoding_table)[0] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ UnicodeEncodeError: 'charmap' codec can't encode character '\ufffd' in position 406: character maps to <undefined> 
@zooba
Copy link
Member Author

zooba commented May 29, 2024

#119747 should deal with the buildbot failure

zooba added a commit that referenced this pull request May 29, 2024
…sion (GH-119426) (cherry picked from commit df93f5d) Co-authored-by: Steve Dower <steve.dower@python.org>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants