gh-113892: Add a extra check to ProactorEventLoop.sock_connect to ensure that the given socket is in non-blocking mode #119519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ure that the given socket is in non-blocking mode
Eclips4 requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners 
Eclips4 added needs backport to 3.12 
| Thanks @Eclips4 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2024
…` to ensure that the given socket is in non-blocking mode (pythonGH-119519) (cherry picked from commit cf3bba3) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
| GH-119912 is a backport of this pull request to the 3.13 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2024
…` to ensure that the given socket is in non-blocking mode (pythonGH-119519) (cherry picked from commit cf3bba3) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
| GH-119913 is a backport of this pull request to the 3.12 branch. |
gvanrossum pushed a commit that referenced this pull request Jun 1, 2024
gvanrossum pushed a commit that referenced this pull request Jun 1, 2024
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
…` to ensure that the given socket is in non-blocking mode (python#119519)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
…` to ensure that the given socket is in non-blocking mode (python#119519)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…` to ensure that the given socket is in non-blocking mode (python#119519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
asyncioProactorEventLoopdidn't check if thesocketis blocking #113892