bpo-29524: Add Objects/call.c file #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Move all functions to call objects in a new Objects/call.c file. * Rename fast_function() to _PyFunction_FastCallKeywords(). * Copy null_error() from Objects/abstract.c * Inline type_error() in call.c to not have to copy it, it was only called once. * Export _PyEval_EvalCodeWithName() since it is now called from call.c.
methane requested changes Feb 11, 2017
| inlines the most primitive frame setup code from | ||
| PyEval_EvalCodeEx(), which vastly reduces the checks that must be | ||
| done before evaluating the frame. | ||
| */ |
Member
There was a problem hiding this comment.
This comment block should be moved to function_code_fastcall().
Member Author
| Oh in fact it was a deliberate choice to remove the comment. Python 3.7 now has a wide range of "fast call" functions which are designed for best performance. Do you think that it's worth it to keep the comment? |
methane approved these changes Feb 12, 2017
Member
methane left a comment
methane left a comment There was a problem hiding this comment.
I just checked all code is moved as-is.
I agree the comment block is not so important.
Member Author
| Thank you for the review. |
Contributor
| Follow-up at #7909 |
paulmon added a commit to paulmon/cpython that referenced this pull request Jan 10, 2019
Windows arm32 - fix failing tests or skip
emmatyping referenced this pull request in emmatyping/cpython Mar 16, 2020
isidentical referenced this pull request in isidentical/cpython Jun 29, 2021
* Handle lines with multi-byte unicode characters properly * Use Py_XDECREF instead of Py_DECREF Co-authored-by: Batuhan Taskaya <isidentical@gmail.com> Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
jaraco pushed a commit that referenced this pull request Dec 2, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2024
…PyFuture refcycles (pythonGH-12… (pythonGH-125476) Revert "pythongh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (pythonGH-124959)" This reverts commit d5dbbf4. (cherry picked from commit e99650b) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
This was referenced Feb 11, 2025
dg-pb pushed a commit to dg-pb/cpython that referenced this pull request Oct 21, 2025
Eclips4 added a commit to Eclips4/cpython that referenced this pull request Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
http://bugs.python.org/issue29524