[3.8] bpo-37269: Correctly optimise conditionals with constant booleans (GH-14071) #14072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…thonGH-14071) Fix a regression introduced by af8646c that was causing code of the form: if True and False: do_something() to be optimized incorrectly, eliminating the block. (cherry picked from commit 05f8318) Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal approved these changes Jun 14, 2019
Contributor Author
| @pablogsal: Status check is done, and it's a success ✅ . |
Contributor Author
| @pablogsal: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor Author
| @pablogsal: Status check is done, and it's a success ✅ . |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced by af8646c that was causing code of the form:
if True and False:
do_something()
to be optimized incorrectly, eliminating the block.
(cherry picked from commit 05f8318)
Co-authored-by: Pablo Galindo Pablogsal@gmail.com
https://bugs.python.org/issue37269