bpo-26353: IDLE adds an unneeded newline when saving a shell window #17103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
terryjreedy approved these changes Nov 12, 2019
Member
terryjreedy left a comment
terryjreedy left a comment There was a problem hiding this comment.
Thank you for finding the key idea needed. I rearranged things a bit and added tests (which was part of the reason for the rearrangement).
terryjreedy added needs backport to 3.7 type-bug 
Contributor
| Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
| GH-17118 is a backport of this pull request to the 3.8 branch. |
| GH-17119 is a backport of this pull request to the 3.7 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2019
…ythonGH-17103) (cherry picked from commit c8b53dc) Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Nov 12, 2019
miss-islington added a commit that referenced this pull request Nov 12, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
IDLE no longer adds an unneeded newline when saving a shell window.
https://bugs.python.org/issue26353