Skip to content

bpo-40334: Improve various PEG-Parser related stuff #19669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 23, 2020
Merged

bpo-40334: Improve various PEG-Parser related stuff #19669

merged 7 commits into from
Apr 23, 2020

Conversation

@lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Apr 23, 2020 •
edited by bedevere-bot
Loading

These are all related to @vstinner's review of the PEP 617 PR.
The most important changes include moving pegen_interface.h
into Include/internal and refactoring some code in
Parser/pegen/pegen.c.

https://bugs.python.org/issue40334
@lysnikolaou
bpo-40334: Improve various PEG-Parser related stuff
70b9712 
These are all related to @vstinner's review of the PEP 617 PR. The most important changes include moving `pegen_interface.h` into `Include/internal` and refactoring some code in `Parser/pegen/pegen.c`.
@lysnikolaou lysnikolaou requested review from a team and pablogsal as code owners April 23, 2020 00:07
@vstinner
Copy link
Member

vstinner commented Apr 23, 2020

Oh, this PR partially conflicts with my PR #19670. Would you mind to review it?
@vstinner vstinner mentioned this pull request Apr 23, 2020
Merged
@lysnikolaou
Copy link
Member Author

lysnikolaou commented Apr 23, 2020

Oh, this PR partially conflicts with my PR #19670. Would you mind to review it?

Of course. Let me just first remove the conflicts from this one.
vstinner
vstinner reviewed Apr 23, 2020
View reviewed changes
@lysnikolaou lysnikolaou requested a review from vstinner April 23, 2020 01:37
vstinner
vstinner reviewed Apr 23, 2020
View reviewed changes
vstinner
vstinner approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@lysnikolaou
Copy link
Member Author

lysnikolaou commented Apr 23, 2020

Thanks for the help, @vstinner!
@pablogsal pablogsal merged commit ebebb64 into python:master Apr 23, 2020
@lysnikolaou lysnikolaou deleted the review branch April 23, 2020 15:38
@imzhuhl imzhuhl mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news

5 participants

@lysnikolaou @vstinner @pablogsal @the-knights-who-say-ni @bedevere-bot