gh-51574: Make tempfile.mkdtemp() always return absolute paths #94612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
Contributor Author
| I tested the test both with and without the fix, and it passes with the fix and fails without it. |
merwok reviewed Jul 7, 2022
merwok reviewed Jul 7, 2022
merwok reviewed Jul 7, 2022
merwok reviewed Jul 7, 2022
Co-authored-by: Éric <merwok@netwok.org>
mblahay approved these changes Apr 24, 2023
Contributor
mblahay left a comment
mblahay left a comment There was a problem hiding this comment.
The changes here are sound.
merwok reviewed Apr 24, 2023
Misc/NEWS.d/next/Library/2022-07-06-11-10-37.gh-issue-51574.sveUeD.rst Outdated Show resolved Hide resolved
…eUeD.rst Suggested by @merwok Co-authored-by: Éric <merwok@netwok.org>
Contributor
| @ambv I have taken a look at this and all seems to be in good order. Can this be moved forward? |
Member
| Merging |
mblahay approved these changes Apr 25, 2023
AlexWaygood approved these changes Apr 25, 2023
Member
AlexWaygood left a comment
AlexWaygood left a comment There was a problem hiding this comment.
Thanks @kj7rrv! This looks good to me. I'll merge once CI passes.
This will just go into 3.12, as there is a small chance of this breaking someone's code if this were backported.
Contributor
| Thank you @AlexWaygood , and congratulations @kj7rrv ! |
itamaro pushed a commit to itamaro/cpython that referenced this pull request Apr 26, 2023
…ython#94612) Co-authored-by: Éric <merwok@netwok.org> Co-authored-by: AlexWaygood <alex.waygood@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.