gh-83004: Clean up refleak in _zoneinfo initialisation #98842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JelleZijlstra approved these changes Nov 2, 2022
Member
| Code looks good, but I think we need a NEWS entry as this fixes a (very unlikely) user-facing issue. |
Contributor Author
Member
| Thanks! I think batching them is fine since the change is simple. |
Misc/NEWS.d/next/Library/2022-11-02-05-54-02.gh-issue-83004.0v8iyw.rst Outdated Show resolved Hide resolved
JelleZijlstra approved these changes Nov 3, 2022
JelleZijlstra approved these changes Nov 6, 2022
JelleZijlstra added awaiting merge needs backport to 3.10 
Contributor
| Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Contributor
| Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
| GH-99163 is a backport of this pull request to the 3.11 branch. |
| GH-99164 is a backport of this pull request to the 3.10 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
miss-islington added a commit that referenced this pull request Nov 6, 2022
miss-islington added a commit that referenced this pull request Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.