Fix relative file paths with fragments #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| @codeclown Thx for contribution. |
Contributor Author
| @evidolob Thanks for the tip! I managed to test the change locally, and it works as expected. Also added an if-else to the test to account for Windows paths. |
evidolob approved these changes Dec 6, 2021
JPinkney approved these changes Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes fragments when schema URL is a local file.
Example of such a reference:
Currently this doesn't work in VS Code:
Error on hover is:
The issue is caused by "#" being turned into "%23" during some path resolve operations. This PR fixes it by excluding the fragment during those operations.
What issues does this PR fix or reference?
Couldn't find a GitHub issue.
Relates somewhat to old PR which added fragment support: #530
Is it tested? How?
Includes automated test in existing suite.
I don't know how to test this with VS Code directly (if you could advice, I'll happily test locally; as a sidenote, CONTRIBUTING.md in this regard would be helpful).