Start using pattern types in libcore

[oli-obk]

cc #135996

[compiler-errors]

Well r=me when/if it does get unblocked.

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[Veykril]

Re rust-analyzer blocker, as it turns out to implement pattern types (to a degree that would unblock this) it comes down to the same architecture changes required as for rust-lang/rust-analyzer#7434 (which I am currently looking into), so that will take a bit.

[rustbot]

Some changes occurred to the CTFE machinery

cc @rust-lang/wg-const-eval

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

[rustbot]

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

[bors]

☔ The latest upstream changes (presumably #148507) made this pull request unmergeable. Please resolve the merge conflicts.

[oli-obk]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: e177b34 (e177b3401e07dfa6c1b49cab6144bfd78d8ee7e1, parent: 8e0b68e63cd2b7b6d18474fe6f49df6fb1570c25)

[rust-timer]

Finished benchmarking commit (e177b34): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.2%, 3.4%]	17
Regressions ❌ (secondary)	0.9%	[0.1%, 3.4%]	12
Improvements ✅ (primary)	-0.6%	[-2.8%, -0.2%]	11
Improvements ✅ (secondary)	-0.7%	[-1.2%, -0.3%]	2
All ❌✅ (primary)	0.7%	[-2.8%, 3.4%]	28

Max RSS (memory usage)

Results (primary -0.0%, secondary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.1%	[1.5%, 5.0%]	3
Regressions ❌ (secondary)	2.2%	[1.2%, 3.0%]	3
Improvements ✅ (primary)	-4.7%	[-4.7%, -4.7%]	2
Improvements ✅ (secondary)	-3.7%	[-4.9%, -1.4%]	10
All ❌✅ (primary)	-0.0%	[-4.7%, 5.0%]	5

Cycles

Results (primary -1.3%, secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	5.0%	[2.6%, 8.8%]	5
Improvements ✅ (primary)	-2.9%	[-3.4%, -2.5%]	2
Improvements ✅ (secondary)	-5.4%	[-8.9%, -1.7%]	8
All ❌✅ (primary)	-1.3%	[-3.4%, 2.1%]	3

Binary size

Results (primary 1.0%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[0.0%, 7.6%]	48
Regressions ❌ (secondary)	1.1%	[0.0%, 7.6%]	15
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	5
Improvements ✅ (secondary)	-1.1%	[-2.1%, -0.0%]	2
All ❌✅ (primary)	1.0%	[-0.1%, 7.6%]	53

Bootstrap: 475.57s -> 475.799s (0.05%)
Artifact size: 390.76 MiB -> 391.12 MiB (0.09%)

[Paladynee]

are these copy -> move changes a good sign?

[bors]

☔ The latest upstream changes (presumably #149013) made this pull request unmergeable. Please resolve the merge conflicts.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rust-log-analyzer]

The job x86_64-gnu-gcc failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

test [mir-opt] tests/mir-opt/unusual_item_types.rs ... ok failures: ---- [mir-opt] tests/mir-opt/pre-codegen/loops.rs stdout ---- 61 scope 42 (inlined alloc::raw_vec::RawVecInner::capacity) { 62 debug self => _39; 63 debug elem_size => const <impl Sized as std::mem::SizedTypeProperties>::SIZE; - let mut _21: (usize) is 0..=2147483647; + let mut _21: (usize) is 0..=9223372036854775807; 65 scope 43 (inlined core::num::niche_types::UsizeNoHighBit::as_inner) { - debug ((self: core::num::niche_types::UsizeNoHighBit).0: (usize) is 0..=2147483647) => _21; + debug ((self: core::num::niche_types::UsizeNoHighBit).0: (usize) is 0..=9223372036854775807) => _21; 67 } 68 } 69 } 256 } 257 258 bb6: { - _21 = copy (((((_2.0: std::vec::Vec<impl Sized>).0: alloc::raw_vec::RawVec<impl Sized>).0: alloc::raw_vec::RawVecInner).1: core::num::niche_types::UsizeNoHighBit).0: (usize) is 0..=2147483647); + _21 = copy (((((_2.0: std::vec::Vec<impl Sized>).0: alloc::raw_vec::RawVec<impl Sized>).0: alloc::raw_vec::RawVecInner).1: core::num::niche_types::UsizeNoHighBit).0: (usize) is 0..=9223372036854775807); 260 _20 = copy _21 as usize (Transmute); 261 goto -> bb7; 262 } thread '[mir-opt] tests/mir-opt/pre-codegen/loops.rs' panicked at src/tools/compiletest/src/runtest/mir_opt.rs:84:21: Actual MIR output differs from expected MIR output /checkout/tests/mir-opt/pre-codegen/loops.vec_move.PreCodegen.after.mir stack backtrace: 5: __rustc::rust_begin_unwind at /rustc/3b4dd9bf1410f8da6329baa36ce5e37673cbbd1f/library/std/src/panicking.rs:698:5 6: core::panicking::panic_fmt at /rustc/3b4dd9bf1410f8da6329baa36ce5e37673cbbd1f/library/core/src/panicking.rs:80:14 

For more information how to resolve CI failures of this job, visit this link.