Rollup of 6 pull requests #148087
Closed
Rollup of 6 pull requests #148087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `needs-asm-support` directive checks whether the host architecture supports inline assembly, not the target architecture. For tests that explicitly specify a target via `--target` in their compile-flags, this directive is incorrect and unnecessary. These tests are cross-compiling to specific targets (like x86_64, arm, aarch64, riscv, etc.) that are already known to have stable asm support. The directive was causing these tests to be incorrectly skipped on hosts that don't support asm, even though the target does. Tests with explicit targets should rely on `needs-llvm-components` to ensure the appropriate backend is available, rather than checking host asm support. Improve documentation about `needs-asm-support` directive.
These same checks feed into `doctest.can_be_merged`, making them redundant.
When working on the stabilization report, I found it annoying to determine what cases were covered because areas of the frontmatter feature were either not in the file name or in inconsistent locations. This moves the area of frontmatter to the start of the file name and the moves to more specific the later in the file name so coverage is easier to see.
…explicit, r=cuviper Remove needs-asm-support directive in tests with explicit targets The `needs-asm-support` directive checks whether the host architecture supports inline assembly, not the target architecture. For tests that explicitly specify a target via `--target` in their compile-flags, this directive is incorrect and unnecessary. These tests are cross-compiling to specific targets (like x86_64, arm, aarch64, riscv, etc.) that are already known to have stable asm support. The directive was causing these tests to be incorrectly skipped on hosts that don't support asm, even though the target does. Tests with explicit targets should rely on `needs-llvm-components` to ensure the appropriate backend is available, rather than checking host asm support.
constify comparison traits on slices r? oli-obk Tracking issue rust-lang#143800
refactor(rustdoc): Remove redundant langstr checks These same checks feed into `doctest.can_be_merged`, making them redundant.
compiletest: Add concrete examples for some config/test path fields Seeing a specific example path can be much more enlightening than trying to figure out what the prose is gesturing towards. Also, in some cases the existing comments were incorrect or misleading, as demonstrated by the example paths. The example paths were determined by dumping them directly out of the config with `dbg!`, and then lightly anonymizing them for example purposes. --- No functional changes. r? jieyouxu
…=joboet Fix compiling `CondVar::wait_timeout` on 32-bit Apple platforms Fixes rust-lang#147776. I feel like there's a cleaner way to write this, but that probably requires further refactoring. The build can be tested with `./x build --target arm64_32-apple-watchos` (or with any other 32-bit Apple target). Tested it works at runtime on an Intel Macbook Pro with macOS 10.12.6, in x86 emulation mode with something similar to `./x test library/std --target x86_64-apple-darwin,i686-apple-darwin`, as well as with a custom test with a timeout of `Duration::from_secs((u32::MAX as u64) + 1)` (which the naive fix would have treated as a duration of 1 second). r? libs CC `@joboet`
test(frontmatter): Rename tests to make coverage more obvious When working on the stabilization report (rust-lang#148051), I found it annoying to determine what cases were covered because areas of the frontmatter feature were either not in the file name or in inconsistent locations. This moves the area of frontmatter to the start of the file name and the moves to more specific the later in the file name so coverage is easier to see. Tracking issue: rust-lang#136889
rustbot added A-compiletest 
Member Author
| @bors r+ rollup=never p=5 |
Collaborator
bors added S-waiting-on-bors Collaborator
bors added a commit that referenced this pull request Oct 25, 2025
Rollup of 6 pull requests Successful merges: - #147406 (Remove needs-asm-support directive in tests with explicit targets) - #147790 (constify comparison traits on slices) - #148056 (refactor(rustdoc): Remove redundant langstr checks) - #148065 (compiletest: Add concrete examples for some config/test path fields) - #148072 (Fix compiling `CondVar::wait_timeout` on 32-bit Apple platforms) - #148073 (test(frontmatter): Rename tests to make coverage more obvious) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
| The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review 
rustbot removed the S-waiting-on-review Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
CondVar::wait_timeouton 32-bit Apple platforms #148072 (Fix compilingCondVar::wait_timeouton 32-bit Apple platforms)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup