- Notifications
You must be signed in to change notification settings - Fork 14.1k
Rollup of 15 pull requests #48520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Rollup of 15 pull requests #48520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We need two-phase borrows of ops to be in the initial NLL release since without them lots of existing code will break. Fixes rust-lang#48129
This updates the book repository, but mostly to include rust-lang/book#1180 TL;DR: the second edition is close enough to done that we should universally recommend it over the first edition.
This reverts commit c6772b4.
This adds an `UnpackedKind` type as a typesafe counterpart to `Kind`. This should make future changes to kinds (such as const generics!) more resilient, as the type-checker should catch more potential issues.
Fix borrow checker unsoundness with unions Fixes rust-lang#45157. After discussion with @nikomatsakis on Gitter, this PR only adds a test since the original issue was resolved elsewhere. r? @nikomatsakis
…richton Stabilize Box::leak Stabilizes the following: + `Box::leak` (`box_leak`, in nightly since 2017-11-23) cc rust-lang#46179 r? @rust-lang/libs
Member Author
| @bors r+ p=1000 |
Collaborator
| 📌 Commit 7ba4afc has been approved by |
Collaborator
| ⌛ Testing commit 7ba4afc with merge fe7075b26eee6f395b2a80efacb46c43aeda3bb2... |
Collaborator
| 💔 Test failed - status-travis |
Member Author
| @bors r+ |
Member Author
| @bors r+ retry |
Collaborator
| 📌 Commit 52047f0 has been approved by |
Collaborator
bors added a commit that referenced this pull request Feb 25, 2018
Collaborator
| ☀️ Test successful - status-appveyor, status-travis |
kennytm-githubbot added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Feb 25, 2018
Tested on commit rust-lang/rust@026339e. 💔 clippy-driver on windows: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk). 💔 clippy-driver on linux: test-pass → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk).
This was referenced Feb 25, 2018
This was referenced Feb 25, 2018
Member
| Hello people from future, please refer to #48481 for the actual |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
&str + String#48392, Update the book to promote second edition #48404, rustdoc: don't crash when an external trait's docs needs to import another trait #48415, Fix parsing of extern paths in types and poly-traits #48441, reset default binding mode when we pass through a&pattern #48448, Introduce UnpackedKind #48452, Allow parentheses indyn (Trait)#48481, Implement multiple patterns with|inif letandwhile let(RFC 2175) #48490, Fix capitalisation in Path#file_name's docs #48499, Remove directorysrc/rt#48503