Avoid ICE caused by suggestion #87795
Merged
+42 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review Contributor Author
| r? @oli-obk |
oli-obk reviewed Aug 10, 2021
estebank force-pushed the erase-lifetimes-in-suggestion branch 2 times, most recently from f80d1bf to d3a3bb4 Compare 
This comment has been minimized.
This comment has been minimized.
When suggesting dereferencing something that can be iterable in a `for` loop, erase lifetimes and use a fresh `ty::ParamEnv` to avoid 'region constraints already solved' panic. Fix rust-lang#87657.
estebank force-pushed the erase-lifetimes-in-suggestion branch from d3a3bb4 to a0bf7d2 Compare 
Contributor
| @bors r+ rollup |
Collaborator
| 📌 Commit a0bf7d2 has been approved by |
bors added S-waiting-on-bors GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 13, 2021
…ion, r=oli-obk Avoid ICE caused by suggestion When suggesting dereferencing something that can be iterable in a `for` loop, erase lifetimes and use a fresh `ty::ParamEnv` to avoid 'region constraints already solved' panic. Fix rust-lang#87657, fix rust-lang#87709, fix rust-lang#87651.
This was referenced Aug 13, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 13, 2021
…laumeGomez Rollup of 4 pull requests Successful merges: - rust-lang#87795 (Avoid ICE caused by suggestion) - rust-lang#87966 (Fix `command-create-pidfd` test inside unprivileged Docker containers) - rust-lang#87969 (Revert "Rollup merge of rust-lang#87779 - Aaron1011:stmt-ast-id, r=petrochenkov") - rust-lang#88005 (Add rustdoc GUI test for headers) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When suggesting dereferencing something that can be iterable in a
forloop, erase lifetimes and use a fresh
ty::ParamEnvto avoid 'regionconstraints already solved' panic.
Fix #87657, fix #87709, fix #87651.