Skip to content

intrinsic-test: Coalescing all intrinsic tests into a single run of the test-file binaries #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 1, 2025
Merged

intrinsic-test: Coalescing all intrinsic tests into a single run of the test-file binaries #1952

merged 9 commits into from
Dec 1, 2025
+98 −92

Conversation

@madhav-madhusoodanan
Copy link
Contributor

@madhav-madhusoodanan madhav-madhusoodanan commented Nov 4, 2025

No description provided.

@madhav-madhusoodanan
Copy link
Contributor Author

madhav-madhusoodanan commented Nov 4, 2025 •
edited
Loading

@folkertdev I was able to run 30% of the intrinsics and get a 17-minute CI runtime.
I'll be exploring some optimizations on how to reduce it further.
folkertdev
folkertdev reviewed Nov 4, 2025
View reviewed changes
Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very encouraging results!
@madhav-madhusoodanan
Copy link
Contributor Author

madhav-madhusoodanan commented Nov 6, 2025

The longest process is the C++/Rust binary runs (which run on a single thread each, in parallel)
This takes about 7 mins.

I think the next optimization would be parallelizing the binary runs themselves.
@sayantn sayantn mentioned this pull request Dec 1, 2025
Open
@folkertdev
Copy link
Contributor

folkertdev commented Dec 1, 2025

@madhav-madhusoodanan is this done (it needs a rebase)?
@madhav-madhusoodanan
Copy link
Contributor Author

madhav-madhusoodanan commented Dec 1, 2025

Apologies for the delay @folkertdev.
I still am implementing the binary run parallelization, which I shall do in another PR perhaps.

For now let's merge this once I rebase
@folkertdev folkertdev marked this pull request as ready for review December 1, 2025 21:28
@rustbot
Copy link
Collaborator

rustbot commented Dec 1, 2025

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@folkertdev folkertdev added this pull request to the merge queue Dec 1, 2025
Merged via the queue into rust-lang:main with commit 3ef10b0 Dec 1, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@madhav-madhusoodanan @folkertdev @rustbot