Skip to content

Commit 7bdf6f3

Browse files
author
Matt Roeschke
committed
use dict(zip()) directly
1 parent 59cbdf7 commit 7bdf6f3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

pandas/io/sql.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -591,7 +591,7 @@ def _execute_insert(self, conn, keys, data_iter):
591591
data_iter : generator of list
592592
Each item contains a list of values to be inserted
593593
"""
594-
data = [{k: v for k, v in zip(keys, row)} for row in data_iter]
594+
data = [dict(zip(keys, row)) for row in data_iter]
595595
conn.execute(self.table.insert(), data)
596596

597597
def _execute_insert_multi(self, conn, keys, data_iter):
@@ -601,7 +601,7 @@ def _execute_insert_multi(self, conn, keys, data_iter):
601601
and tables containing a few columns
602602
but performance degrades quickly with increase of columns.
603603
"""
604-
data = [{k: v for k, v in zip(keys, row)} for row in data_iter]
604+
data = [dict(zip(keys, row)) for row in data_iter]
605605
conn.execute(self.table.insert(data))
606606

607607
def insert_data(self):

pandas/tests/io/test_sql.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ def _to_sql_method_callable(self):
443443

444444
def sample(pd_table, conn, keys, data_iter):
445445
check.append(1)
446-
data = [{k: v for k, v in zip(keys, row)} for row in data_iter]
446+
data = [dict(zip(keys, row)) for row in data_iter]
447447
conn.execute(pd_table.table.insert(), data)
448448
self.drop_table('test_frame1')
449449

0 commit comments

Comments
 (0)