requirements: Include main.in contents within dev.in #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This way we only need to install one requirements/*.txt so the version numbers in the two cannot clash. Dependabot does not seem to handle "-r main.in" or "-r main.txt" very well so that was not used here. Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
woodruffw approved these changes Oct 14, 2025
Member
woodruffw left a comment
woodruffw left a comment There was a problem hiding this comment.
Grumble, Dependabot 🙂
Seems fine to me, but I think long term we should maybe use a pylock.toml or even just uv's lockfile format to express these kinds of composite environments. But Dependabot will probably have similar issues there...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This way we only need to install one requirements/*.txt at any one time so the version numbers in the two cannot clash.
Dependabot does not seem to handle "-r main.in" or "-r main.txt" very well so that was not used here.
I'll take improve suggestions but based on my quick tests in a fork, dependabot doesn't cope with "requirements files in requirements files" well.
This should let dependabot unbreak #220