GH Actions: various updates (#283)

* GH Actions: fix use of deprecated `set-output` GitHub has deprecated the use of `set-output` (and `set-state`) in favour of new environment files. This commit updates workflows to use the new methodology. Refs: * https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ * https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#environment-files * GH Actions: harden the workflow against PHPCS ruleset errors If there is a ruleset error, the `cs2pr` action doesn't receive an `xml` report and exits with a `0` error code, even though the PHPCS run failed (though not on CS errors, but on a ruleset error). This changes the GH Actions workflow to allow for that situation and still fail the build in that case. Co-authored-by: jrfnl <jrfnl@users.noreply.github.com>

Author: jrfnl

.github/workflows/csqa.yml

@@ -64,10 +64,11 @@ jobs:
 
  # Check the code-style consistency of the PHP files.
  - name: Check PHP code style
- continue-on-error: true
+ id: phpcs
  run: composer lint -- --no-cache --report-full --report-checkstyle=./phpcs-report.xml
 
  - name: Show PHPCS results in PR
+ if: ${{ always() && steps.phpcs.outcome == 'failure' }}
  run: cs2pr ./phpcs-report.xml
 
  static-analysis:

.github/workflows/test.yml

@@ -65,9 +65,9 @@ jobs:
  # On stable PHPCS versions, allow for PHP deprecation notices.
  # Unit tests don't need to fail on those for stable releases where those issues won't get fixed anymore.
  if [ "${{ matrix.phpcs_version }}" != "dev-master" ]; then
- echo '::set-output name=PHP_INI::error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On, zend.assertions=1'
+ echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On, zend.assertions=1' >> $GITHUB_OUTPUT
  else
- echo '::set-output name=PHP_INI::error_reporting=-1, display_errors=On, zend.assertions=1'
+ echo 'PHP_INI=error_reporting=-1, display_errors=On, zend.assertions=1' >> $GITHUB_OUTPUT
  fi
 
  - name: Install PHP
@@ -133,9 +133,9 @@ jobs:
  # On stable PHPCS versions, allow for PHP deprecation notices.
  # Unit tests don't need to fail on those for stable releases where those issues won't get fixed anymore.
  if [ "${{ matrix.phpcs_version }}" != "dev-master" ]; then
- echo '::set-output name=PHP_INI::error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On, zend.assertions=1'
+ echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On, zend.assertions=1' >> $GITHUB_OUTPUT
  else
- echo '::set-output name=PHP_INI::error_reporting=-1, display_errors=On, zend.assertions=1'
+ echo 'PHP_INI=error_reporting=-1, display_errors=On, zend.assertions=1' >> $GITHUB_OUTPUT
  fi
 
  - name: Install PHP
@@ -156,7 +156,7 @@ jobs:
 
  - name: Grab PHPUnit version
  id: phpunit_version
- run: echo ::set-output name=VERSION::$(vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')
+ run: echo "VERSION=$(vendor/bin/phpunit --version | grep --only-matching --max-count=1 --extended-regexp '\b[0-9]+\.[0-9]+')" >> $GITHUB_OUTPUT
 
  - name: "DEBUG: Show grabbed version"
  run: echo ${{ steps.phpunit_version.outputs.VERSION }}