Skip to content

Commit 36c474e

Browse files
committed
fix phpunit options, add values to our percy options
1 parent f1cfba9 commit 36c474e

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

src/Console/DuskCommand.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ class DuskCommand extends BaseDuskCommand
1616
protected $signature = 'dusk
1717
{--without-tty : Disable output to TTY}
1818
{--without-percy : Disable percy snapshots}
19-
{--percy-target-branch : Set the base branch for comparison}
20-
{--percy-target-commit : Set the base commit SHA for comparison}';
19+
{--percy-target-branch= : Set the base branch for comparison}
20+
{--percy-target-commit= : Set the base commit SHA for comparison}';
2121

2222
/**
2323
* Execute the console command.
@@ -108,9 +108,8 @@ protected function process()
108108
*/
109109
protected function processOptions()
110110
{
111-
return array_diff(
112-
array_slice($_SERVER['argv'], 2),
113-
['--without-tty', '--without-percy', '--percy-target-branch', '--percy-target-commit']
114-
);
111+
return array_filter(array_slice($_SERVER['argv'], 2), function($param) {
112+
return !starts_with($param, ['--without-tty', '--without-percy', '--percy-target-branch', '--percy-target-commit']);
113+
});
115114
}
116115
}

src/Console/DuskFailsCommand.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ class DuskFailsCommand extends DuskCommand
1212
protected $signature = 'dusk:fails
1313
{--without-tty : Disable output to TTY}
1414
{--without-percy : Disable percy snapshots}
15-
{--percy-target-branch : Set the base branch for comparison}
16-
{--percy-target-commit : Set the base commit SHA for comparison}';
15+
{--percy-target-branch= : Set the base branch for comparison}
16+
{--percy-target-commit= : Set the base commit SHA for comparison}';
1717

1818
/**
1919
* The console command description.

0 commit comments

Comments
 (0)