replace use of filter{}.isEmpty with more efficient options #6877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
motivation: small perforamnce gains changes: * replace filter{}.isEmpty with more efficient options like contains.where{ } 
tomerd force-pushed the fix/no-filter-then-empty branch from efeb151 to 34987fc Compare 
tomerd commented Sep 7, 2023
| contents += "(allow mach-lookup (global-name \"com.apple.lsd.mapdb\"))\n" | ||
| | ||
| if allowNetworkConnections.filter({ $0 != .none }).isEmpty == false { | ||
| //if allowNetworkConnections.filter({ $0 != .none }).isEmpty == false { |
Contributor Author
There was a problem hiding this comment.
left the original one (here and elsewhere) to make sure I did not get it wrong. will remove when ready to merge
ie-ahm-robox approved these changes Sep 8, 2023
neonichu requested changes Sep 8, 2023
Contributor
| Not sure I am a fan of this, it seems like change for the sake of it, since none of the call sites seem like they would ever actually process collections of significant size. There's a real cost to these because they obscure the history, the real reason for any of this code is now one hop away. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
motivation: small perforamnce gains
changes: replace filter{}.isEmpty with more efficient options like contains.where{ }