Skip to content

Commit 12e8fea

Browse files
committed
fix: treat warnings as errors
1 parent 8b4d590 commit 12e8fea

File tree

67 files changed

+134
-51
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

67 files changed

+134
-51
lines changed

.gitignore

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,9 @@ UpgradeLog*.XML
111111
/SpreadStreamProcessing/.vs
112112
/SpreadProcessing/.vs
113113
/PdfProcessing/.vs
114+
/PdfProcessing/AddWatermark/.vs
115+
/PdfProcessing/CreateDocumentWithImages/.vs
116+
/PdfProcessing/CreateInteractiveForms/.vs
114117
/PdfProcessing/CreatePdfUsingRadFixedDocumentEditor/.vs
115118
/PdfProcessing/DrawHeaderFooter/.vs
116119
/PdfProcessing/ExportUIElement/.vs
@@ -120,8 +123,16 @@ UpgradeLog*.XML
120123
/PdfProcessing/ModifyForms/.vs
121124
/PdfProcessing/PdfStreamWriterPerformance/.vs
122125
/PdfProcessing/PdfViewerIntegration/.vs
126+
/SpreadProcessing/ConvertDocuments/.vs
127+
/SpreadProcessing/CreateModifyExport/.vs
128+
/SpreadProcessing/ExportChart/.vs
129+
/SpreadProcessing/GenerateDocuments/.vs
130+
/SpreadStreamProcessing/AppendWorksheetToExistingWorkbook/.vs
131+
/SpreadStreamProcessing/GenerateDocument/.vs
123132
/WordsProcessing/ContentControls/.vs
124133
/WordsProcessing/ConvertDocuments/.vs
125134
/WordsProcessing/GenerateDocument/.vs
126135
/WordsProcessing/HtmlGenerator/.vs
127136
/WordsProcessing/MailMerge/.vs
137+
/ZipLibrary/CreateZipArchive/.vs
138+
/ZipLibrary/ExtractZipArchiveToDirectory/.vs

PdfProcessing/AddWatermark/AddWatermark.csproj

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
<AppDesignerFolder>Properties</AppDesignerFolder>
1010
<RootNamespace>WatermarkTextDemo</RootNamespace>
1111
<AssemblyName>WatermarkTextDemo</AssemblyName>
12-
<TargetFrameworkVersion>v4.6.2</TargetFrameworkVersion>
13-
<FileAlignment>512</FileAlignment>
14-
<TargetFrameworkProfile />
12+
<TargetFrameworkVersion>v4.6.2</TargetFrameworkVersion>
13+
<FileAlignment>512</FileAlignment>
14+
<TargetFrameworkProfile />
1515
<SccProjectName>SAK</SccProjectName>
1616
<SccLocalPath>SAK</SccLocalPath>
1717
<SccAuxPath>SAK</SccAuxPath>
@@ -27,6 +27,7 @@
2727
<ErrorReport>prompt</ErrorReport>
2828
<WarningLevel>4</WarningLevel>
2929
<Prefer32Bit>false</Prefer32Bit>
30+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
3031
</PropertyGroup>
3132
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
3233
<PlatformTarget>AnyCPU</PlatformTarget>

PdfProcessing/AddWatermark/AddWatermark_NetStandard.csproj

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
1-
<Project Sdk="Microsoft.NET.Sdk">
1+
<Project Sdk="Microsoft.NET.Sdk">
22
<PropertyGroup>
33
<OutputType>Exe</OutputType>
44
<TargetFramework>net9.0</TargetFramework>
55
</PropertyGroup>
66
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
77
<NoWarn>1701;1702;CA1707</NoWarn>
8+
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
89
</PropertyGroup>
910
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
1011
<NoWarn>1701;1702;CA1707</NoWarn>
12+
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
1113
</PropertyGroup>
1214
<ItemGroup>
1315
<Compile Remove="Properties\AssemblyInfo.cs" />

PdfProcessing/AddWatermark/Program.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ static void Main()
3636
private static RadFixedDocument ImportDocument(string fileName)
3737
{
3838
PdfFormatProvider provider = new PdfFormatProvider();
39-
RadFixedDocument document = provider.Import(File.ReadAllBytes(fileName));
39+
RadFixedDocument document = provider.Import(File.ReadAllBytes(fileName), TimeSpan.FromSeconds(15));
4040

4141
return document;
4242
}
@@ -48,7 +48,7 @@ private static void ExportAndViewPdf(RadFixedDocument document, string exportFil
4848
File.Delete(exportFileName);
4949
}
5050

51-
File.WriteAllBytes(exportFileName, new PdfFormatProvider().Export(document));
51+
File.WriteAllBytes(exportFileName, new PdfFormatProvider().Export(document, TimeSpan.FromSeconds(15)));
5252
ProcessStartInfo psi = new ProcessStartInfo()
5353
{
5454
FileName = exportFileName,

PdfProcessing/CreateDocumentWithImages/CreateDocumentWithImages.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
<DefineConstants>DEBUG;TRACE</DefineConstants>
4343
<ErrorReport>prompt</ErrorReport>
4444
<WarningLevel>4</WarningLevel>
45+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
4546
</PropertyGroup>
4647
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
4748
<PlatformTarget>AnyCPU</PlatformTarget>

PdfProcessing/CreateDocumentWithImages/CreateDocumentWithImages_NetStandard.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@
77
</PropertyGroup>
88
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
99
<NoWarn>1701;1702;CA1707</NoWarn>
10+
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
1011
</PropertyGroup>
1112
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
1213
<NoWarn>1701;1702;CA1707</NoWarn>
14+
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
1315
</PropertyGroup>
1416
<ItemGroup>
1517
<Compile Remove="Properties\AssemblyInfo.cs" />

PdfProcessing/CreateDocumentWithImages/DocumentGenerator.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
using System;
22
using System.Diagnostics;
33
using System.IO;
4+
using System.Threading;
45
#if NETCOREAPP
56
using Telerik.Documents.Primitives;
67
#else
@@ -50,7 +51,7 @@ public void SaveFile(string filePath)
5051
using (Stream stream = File.OpenWrite(resultFile))
5152
{
5253
provider.ExportSettings.ImageQuality = this.imageQuality;
53-
provider.Export(this.document, stream);
54+
provider.Export(this.document, stream, TimeSpan.FromSeconds(15));
5455
}
5556

5657
Console.WriteLine("Document created.");
@@ -124,7 +125,7 @@ private void AddPageWithImage(string description, ImageSource imageSource)
124125
block.HorizontalAlignment = Telerik.Windows.Documents.Fixed.Model.Editing.Flow.HorizontalAlignment.Center;
125126
block.TextProperties.FontSize = 22;
126127
block.InsertText(description);
127-
Size blockSize = block.Measure(RemainingPageSize);
128+
Size blockSize = block.Measure(RemainingPageSize, CancellationToken.None);
128129
editor.DrawBlock(block, RemainingPageSize);
129130

130131
editor.Position.Translate(Margins.Left, blockSize.Height + Margins.Top + 20);

PdfProcessing/CreateInteractiveForms/CreateInteractiveForms.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
<DefineConstants>DEBUG;TRACE</DefineConstants>
2626
<ErrorReport>prompt</ErrorReport>
2727
<WarningLevel>4</WarningLevel>
28+
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
2829
</PropertyGroup>
2930
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
3031
<PlatformTarget>AnyCPU</PlatformTarget>

PdfProcessing/CreateInteractiveForms/CreateInteractiveForms_NetStandard.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@
77
</PropertyGroup>
88
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
99
<NoWarn>1701;1702;CA1707</NoWarn>
10+
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
1011
</PropertyGroup>
1112
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
1213
<NoWarn>1701;1702;CA1707</NoWarn>
14+
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
1315
</PropertyGroup>
1416
<ItemGroup>
1517
<Compile Remove="Properties\AssemblyInfo.cs" />

PdfProcessing/CreateInteractiveForms/Program.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ private static void Main(string[] args)
2727
File.Delete(fileName);
2828
}
2929

30-
File.WriteAllBytes(fileName, new PdfFormatProvider().Export(document));
30+
File.WriteAllBytes(fileName, new PdfFormatProvider().Export(document, TimeSpan.FromSeconds(15)));
3131

3232
Console.WriteLine("Document created.");
3333

0 commit comments

Comments
 (0)