KO : docs/site/ko/tutorials/text/text_classification_rnn.ipynb #1163

Ahnseokchan · 2019-11-02T10:48:16Z

translate text_classification_rnn.ipynb
EN -> KO

EN : https://github.com/tensorflow/docs/blob/master/site/en/tutorials/text/text_classification_rnn.ipynb

번역 작업 시작하겠습니다.

tfdocsbot · 2019-11-02T10:48:18Z

Preview and run these notebook edits with Google Colab:

site/ko/tutorials/text/text_classification_rnn.ipynb

Notebook diffs available on ReviewNB.com.

tfdocsbot · 2019-11-02T10:48:19Z

Reviewers added, please take a look.
@rickiepark, @cre8tor, @Choiuijin1125, @JKIsaacLee, @NoelBird, @wckim

When your review is finished, approve the pull request or include "LGTM" in your comment.

googlebot · 2019-11-02T10:48:26Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2019-11-05T01:50:12Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Ahnseokchan

Modify text_classification_rnn.ipynb and translation is complete

Choiuijin1125

Thank you for a great contribution :)

site/ko/tutorials/text/text_classification_rnn.ipynb

Choiuijin1125 · 2019-11-05T02:15:02Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ " \u003ca target=\"_blank\" href=\"https://github.com/tensorflow/docs/blob/master/site/en/tutorials/text/text_classification_rnn.ipynb\"\u003e\u003cimg src=\"https://www.tensorflow.org/images/GitHub-Mark-32px.png\" /\u003e깃허브(GitHub)소스 보기\u003c/a\u003e\n",
+ " \u003c/td\u003e\n",
+ " \u003ctd\u003e\n",
+ " \u003ca href=\"https://storage.googleapis.com/tensorflow_docs/docs/site/en/tutorials/text/text_classification_rnn.ipynb\"\u003e\u003cimg src=\"https://www.tensorflow.org/images/download_logo_32px.png\" /\u003e노트북에 다운로드\u003c/a\u003e\n",


en/tutorials → ko/tutorials

Is it supported to download notebook file on korean translation?

Choiuijin1125 · 2019-11-05T02:22:12Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ "sample_string = 'Hello TensorFlow.'\n",
+ "\n",
+ "encoded_string = encoder.encode(sample_string)\n",
+ "print ('인코딩된 문자열은 {}'.format(encoded_string))\n",


Why don't you del postposition '은' ? just for consistency such as
인코딩된 문자열
원본 문자열

Choiuijin1125 · 2019-11-05T02:24:58Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ "id": "GlYWqhTVlUyQ"
+ },
+ "source": [
+ "## 학습을 위한 데이터 준비"


We mostly distinguish between training and learning so I suggest
'학습을 위한 데이터 준비' → '훈련을 위한 데이터 준비'

Choiuijin1125 · 2019-11-05T02:29:36Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ ]
+ },
+ {
+ "cell_type": "markdown",


Please add declaration :) you can refer the other Ko document
'Note: 이 문서는 텐서플로 커뮤니티에서 번역했습니다. ...`

I think it's not an original declaration, this is the original declaration can u change it?

Note: 이 문서는 텐서플로 커뮤니티에서 번역했습니다. 커뮤니티 번역 활동의 특성상 정확한 번역과 최신 내용을 반영하기 위해 노력함에도 불구하고 공식 영문 문서의 내용과 일치하지 않을 수 있습니다. 이 번역에 개선할 부분이 있다면 tensorflow/docs 깃헙 저장소로 풀 리퀘스트를 보내주시기 바랍니다. 문서 번역이나 리뷰에 참여하려면 docs-ko@tensorflow.org로 메일을 보내주시기 바랍니다.

Choiuijin1125 · 2019-11-05T02:34:48Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ "\n",
+ "순환 인공 신경망(RNN)은 요소를 반복하여 시퀀스 입력을 처리합니다. RNN은 출력을 한 단계에서 입력으로 전달한 다음에 다음 단계로 전달합니다.\n",
+ "\n",
+ "`tf.keras.layers.Bidirectional` 래퍼도 RNN 레이어와 함께 사용할 수 있습니다. 이는 RNN 계층을 통해 입력을 앞뒤로 전파 한 다음 출력을 연결합니다. 이것은 RNN이 장거리 종속성을 학습하는데 도움을 줍니다."


I'm not sure but I think it's more fit 장기(long-term) than 장거리
Just consider my option, thanks :)

Choiuijin1125 · 2019-11-05T02:35:50Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ "id": "zIwH3nto596k"
+ },
+ "source": [
+ "## 모델 학습하기"


For the same reason '학습하기' 훈련하기'

site/ko/tutorials/text/text_classification_rnn.ipynb

Ahnseokchan

modify complete

two files

Ahnseokchan · 2019-11-22T02:15:32Z

check please..

Choiuijin1125

@Ahnseokchan So for the late reply, I can check it regularly since now thanks :)

Choiuijin1125 · 2019-12-02T04:24:13Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ ]
+ },
+ {
+ "cell_type": "markdown",


I think it's not an original declaration, this is the original declaration can u change it?

Note: 이 문서는 텐서플로 커뮤니티에서 번역했습니다. 커뮤니티 번역 활동의 특성상 정확한 번역과 최신 내용을 반영하기 위해 노력함에도 불구하고 공식 영문 문서의 내용과 일치하지 않을 수 있습니다. 이 번역에 개선할 부분이 있다면 tensorflow/docs 깃헙 저장소로 풀 리퀘스트를 보내주시기 바랍니다. 문서 번역이나 리뷰에 참여하려면 docs-ko@tensorflow.org로 메일을 보내주시기 바랍니다.

Choiuijin1125 · 2019-12-02T04:25:06Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ "source": [
+ "[GRU layers](https://www.tensorflow.org/api_docs/python/tf/keras/layers/GRU)과 같은 기존의 다른 반복 계층을 확인합니다..\n",
+ "\n",
+ "만약 custom RNN 빌드에 관심이 있으시다면, [Keras RNN Guide](../../guide/keras/rnn.ipynb)를 보길 바랍니다..\n"


We can translate 'custom' as '사용자 정의', So I suggest '사용자 정의 RNN' or '사용자 정의 순환신경망' and '케라스 순환신경망 가이드'

Choiuijin1125 · 2019-12-08T11:25:07Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ "id": "DwSE_386uhxD"
+ },
+ "source": [
+ "위의 모델은 시퀀스에 적용된 패딩을 가리지 않습니다. 패딩 된 시퀀스를 학습하고 패딩되지 않은 시퀀스를 테스트하면 왜곡이 일어날 수 있습니다. 이상적으로 이를 피하기 위하여 [마스킹을 사용](../../guide/keras/masking_and_padding)하지만 아래에서 볼 수 있듯이 출력에는 약간의 영향만 미칩니다.\n",


[마스킹을 사용] → [마스킹]을 사용 :)

Choiuijin1125 · 2019-12-08T11:27:49Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ "id": "lUWearf0Gw-p"
+ },
+ "source": [
+ "Note: 이 문서는 텐서플로 커뮤니티에서 번역했습니다. 이 번역에 개선할 부분이 있다면 tensorflow/docs 깃헙 저장소로 풀 리퀘스트를 보내주시기 바랍니다. 텍스트 분류 튜토리얼은 감정 분석을 위한 [IMDB 대형 영화 리뷰 데이터셋](http://ai.stanford.edu/~amaas/data/sentiment/)에서 [순환 인공신경망](https://developers.google.com/machine-learning/glossary/#recurrent_neural_network)을 훈련시킵니다."


We mostly translate 'RNN' as '순환신경망' so I suggest '순환신경망'

Choiuijin1125 · 2019-12-08T11:28:31Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ "\n",
+ "이 인덱스-조회는 one-hot 인코딩 된 벡터를 `tf.keras.layers.Dense` 레이어를 통해 전달하는 작업보다 훨씬 효율적입니다.\n",
+ "\n",
+ "순환 인공 신경망(RNN)은 요소를 반복하여 시퀀스 입력을 처리합니다. RNN은 출력을 한 단계에서 입력으로 전달한 다음에 다음 단계로 전달합니다.\n",


'순환 인공 신경망' → '순환신경망' :)

Choiuijin1125 · 2020-01-12T10:49:14Z

@lamberta Hi billy.. :), this PR is LGTM.
Thanks

lamberta · 2020-01-13T18:36:23Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ " \u003ca target=\"_blank\" href=\"https://www.tensorflow.org/tutorials/text/text_classification_rnn\"\u003e\u003cimg src=\"https://www.tensorflow.org/images/tf_logo_32px.png\" /\u003eTensorFlow에서 보기\u003c/a\u003e\n",
+ " \u003c/td\u003e\n",
+ " \u003ctd\u003e\n",
+ " \u003ca target=\"_blank\" href=\"https://colab.research.google.com/github/tensorflow/docs/blob/master/site/en/tutorials/text/text_classification_rnn.ipynb\"\u003e\u003cimg src=\"https://www.tensorflow.org/images/colab_logo_32px.png\" /\u003e구글 코랩(Colab)에서 실행하기\u003c/a\u003e\n",


Suggested change

" \u003ca target=\"_blank\" href=\"https://colab.research.google.com/github/tensorflow/docs/blob/master/site/en/tutorials/text/text_classification_rnn.ipynb\"\u003e\u003cimg src=\"https://www.tensorflow.org/images/colab_logo_32px.png\" /\u003e구글 코랩(Colab)에서 실행하기\u003c/a\u003e\n",

" \u003ca target=\"_blank\" href=\"https://colab.research.google.com/github/tensorflow/docs/blob/master/site/ko/tutorials/text/text_classification_rnn.ipynb\"\u003e\u003cimg src=\"https://www.tensorflow.org/images/colab_logo_32px.png\" /\u003e구글 코랩(Colab)에서 실행하기\u003c/a\u003e\n",

Point to Korean notebook :)

lamberta · 2020-01-13T18:36:48Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ "id": "UQK2Na3Z_aMx"
+ },
+ "outputs": [],
+ "source": [


Remove empty code cell at the end

lamberta · 2020-01-13T18:39:45Z

site/ko/tutorials/text/text_classification_rnn.ipynb

+ },
+ "outputs": [],
+ "source": [
+ "train_dataset = train_dataset.shuffle(BUFFER_SIZE)\n",


Notebook is throwing an error:
AttributeError: 'ShuffleDataset' object has no attribute 'output_shapes'

Can you double-check this notebook against the one in en/ ? Thanks

Hi Billy, Oh, it's because of the version issue. can you close this PR? I'll make new PR for this document(there is no response from a translator.. :))

lamberta · 2020-01-14T17:44:40Z

Thanks for the submission. Closing for @Choiuijin1125 to resolve remaining issues. Thanks

Ahnseokchan added 6 commits October 28, 2019 12:36

text_classification_rnn.ipynb

d18362a

번역 작업 시작하겠습니다.

Update text_classification_rnn.ipynb

0473c7e

Update text_classification_rnn.ipynb

fd40a71

Update text_classification_rnn.ipynb

c725c0f

Update text_classification_rnn.ipynb

cd239e2

Update text_classification_rnn.ipynb

abccfbb

Ahnseokchan requested review from MarkDaoust and lamberta as code owners November 2, 2019 10:48

tfdocsbot added ko translation Community-provided translation for certain languages labels Nov 2, 2019

googlebot added the cla: no CLA has not been signed label Nov 2, 2019

Ahnseokchan added 4 commits November 5, 2019 10:30

Update text_classification_rnn.ipynb

2103003

Update text_classification_rnn.ipynb

5b3316b

Update text_classification_rnn.ipynb

8dec0c5

Update text_classification_rnn.ipynb

a4223d5

googlebot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Nov 5, 2019

Update text_classification_rnn.ipynb

28b5e83

Ahnseokchan commented Nov 5, 2019

View reviewed changes

Add files via upload

bf31be2

Choiuijin1125 reviewed Nov 5, 2019

View reviewed changes

Ahnseokchan added 5 commits November 5, 2019 11:41

Update transformer.ipynb

67c28ab

Update transformer.ipynb

5a415fb

Update transformer.ipynb

abedb02

Update text_classification_rnn.ipynb

21f808f

Update text_classification_rnn.ipynb

5217e6f

Ahnseokchan added 6 commits November 5, 2019 16:33

Update text_classification_rnn.ipynb

6ba0057

Update text_classification_rnn.ipynb

7aa76fa

Add files via upload

744fb75

Update test.ipynb

1fcdf98

Update test.ipynb

79f38bf

Update text_classification_rnn.ipynb

07b8adf

Ahnseokchan commented Nov 5, 2019

View reviewed changes

Ahnseokchan added 14 commits November 18, 2019 01:57

Delete test.ipynb

2e03d2f

Update transformer.ipynb

52c03b7

Update transformer.ipynb

c5ed071

Update transformer.ipynb

738ebea

Update transformer.ipynb

2d7a96c

Update transformer.ipynb

ae7db72

Update transformer.ipynb

1d15a15

Update transformer.ipynb

0d8adc2

Update transformer.ipynb

a17f39a

Update transformer.ipynb

c4cfe2e

Update transformer.ipynb

5db4355

Update transformer.ipynb

df4c579

Update text_classification_rnn.ipynb

58c592a

Delete transformer.ipynb

11f3e83

two files

Choiuijin1125 reviewed Dec 8, 2019

View reviewed changes

tfdocsbot added kokoro:force-run lgtm Community-added approval labels Jan 12, 2020

kokoro-team removed the kokoro:force-run label Jan 12, 2020

lamberta requested changes Jan 13, 2020

View reviewed changes

lamberta closed this Jan 14, 2020

	" \u003ca target=\"_blank\" href=\"https://colab.research.google.com/github/tensorflow/docs/blob/master/site/en/tutorials/text/text_classification_rnn.ipynb\"\u003e\u003cimg src=\"https://www.tensorflow.org/images/colab_logo_32px.png\" /\u003e구글 코랩(Colab)에서 실행하기\u003c/a\u003e\n",
	" \u003ca target=\"_blank\" href=\"https://colab.research.google.com/github/tensorflow/docs/blob/master/site/ko/tutorials/text/text_classification_rnn.ipynb\"\u003e\u003cimg src=\"https://www.tensorflow.org/images/colab_logo_32px.png\" /\u003e구글 코랩(Colab)에서 실행하기\u003c/a\u003e\n",

KO : docs/site/ko/tutorials/text/text_classification_rnn.ipynb #1163

KO : docs/site/ko/tutorials/text/text_classification_rnn.ipynb #1163

Uh oh!

Conversation

Ahnseokchan commented Nov 2, 2019

tfdocsbot commented Nov 2, 2019

tfdocsbot commented Nov 2, 2019

googlebot commented Nov 2, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Nov 5, 2019

Ahnseokchan left a comment

Choose a reason for hiding this comment

Choiuijin1125 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Ahnseokchan left a comment

Choose a reason for hiding this comment

Ahnseokchan commented Nov 22, 2019

Choiuijin1125 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choiuijin1125 commented Jan 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choiuijin1125 Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

lamberta commented Jan 14, 2020

Labels

7 participants

Choiuijin1125 Jan 14, 2020 •

edited

Loading