Skip to content

Conversation

@PeterJaq
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes CLA has been signed label Jun 17, 2019
@tfdocsbot tfdocsbot added translation Community-provided translation for certain languages zh-cn labels Jun 17, 2019
@tfdocsbot
Copy link
Collaborator

Reviewers added, please take a look.
@kuri-leo

When your review is finished, approve the pull request or include "LGTM" in your comment.

@lamberta
Copy link
Member

Thanks, Jiang.

@duanw0916, can you please find a reviewer for this pull request? Thank you

@kuri-leo
Copy link
Contributor

Thanks, Jiang.

@duanw0916, can you please find a reviewer for this pull request? Thank you

Hi @lamberta, Sorry for my temporary disappearance but it will continue to the next week as I'm deeply trapped in the nightmare of final exams 🤦‍♂

I will be back as soon as my college troubles were finished (or I was finished, and review those left PRs & give patches to the merged (They seem to have problems left ).

Thanks

Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no CLA has not been signed and removed cla: yes CLA has been signed labels Jul 1, 2019
PeterJaq and others added 10 commits July 1, 2019 16:13
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
Co-Authored-By: kjlintong <40327910+kjlintong@users.noreply.github.com>
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@lamberta
Copy link
Member

lamberta commented Jul 2, 2019

@kuri-leo No worries at all! Appreciate all your work here to build the community and please do well on your exams :)

Some more reviewers have graciously volunteered to help. FYI @JayYip, @yantaozhao, @loveunk, @Wind2esg

Thank you, all!

@kuri-leo
Copy link
Contributor

mark, review during weekend

PeterJaq and others added 7 commits July 16, 2019 12:36
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes CLA has been signed and removed cla: no CLA has not been signed labels Aug 12, 2019
Co-Authored-By: kurileo <twkuri@gmail.com>
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

PeterJaq and others added 9 commits August 12, 2019 21:47
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Co-Authored-By: kurileo <twkuri@gmail.com>
Copy link
Contributor

@kuri-leo kuri-leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lamberta lamberta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all!

@lamberta lamberta added the ready to pull Start merge process label Aug 12, 2019
@TensorFlow-Docs-Copybara TensorFlow-Docs-Copybara merged commit ffeff2f into tensorflow:master Aug 12, 2019
TensorFlow-Docs-Copybara pushed a commit that referenced this pull request Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes CLA has been signed lgtm Community-added approval ready to pull Start merge process translation Community-provided translation for certain languages zh-cn

8 participants