Skip to content

Conversation

@holblin
Copy link
Contributor

@holblin holblin commented Jul 15, 2022

What:

Migrate the dependency css to @adobe/css to reduce maintained dependencies.

Closes #435

Why:

CSS package is not maintained anymore and has some sub-dependencies which are deprecated.

How:

Change the import

Checklist:

  • Documentation N/A
  • Tests N/A
  • Updated Type Definitions N/A
  • Ready to be merged
@holblin
Copy link
Contributor Author

holblin commented Jul 15, 2022

Note: The version 4 of @adobe/css-tools is very recent. I used import {parse} from '@adobe/css-tools/dist/cjs/cssTools' to make sure it load the cjs build and not the umd build. If someone knows why jest-dom try to load the umd build instead of the cjs and have a solution, feel free to share :-)

@MichaelDeBoey MichaelDeBoey requested a review from a team July 17, 2022 14:21
@codecov
Copy link

codecov bot commented Jul 17, 2022

Codecov Report

Merging #470 (2594583) into main (af18453) will not change coverage.
The diff coverage is 100.00%.

@@ Coverage Diff @@ ## main #470 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 26 26 Lines 630 630 Branches 234 236 +2 ========================================= Hits 630 630 
Impacted Files Coverage Δ
src/utils.js 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not a current maintainer. If nobody merges in the next week or so though I'll go ahead and merge

@holblin
Copy link
Contributor Author

holblin commented Aug 4, 2022

@kentcdodds I updated the import to solve the CJS import path that I was using :-)
Could you merge it when you get some time? 😇 Thanks!

@MichaelDeBoey MichaelDeBoey requested review from a team and kentcdodds August 4, 2022 11:30
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@kentcdodds kentcdodds merged commit 948d90f into testing-library:main Aug 4, 2022
@github-actions
Copy link

github-actions bot commented Aug 4, 2022

🎉 This PR is included in version 5.16.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@holblin holblin deleted the migrate-css branch August 4, 2022 23:12
CrispyBaguette pushed a commit to CrispyBaguette/wasm-palette-converter that referenced this pull request Nov 8, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) | dependencies | minor | [`5.16.4` -> `5.17.0`](https://renovatebot.com/diffs/npm/@testing-library%2fjest-dom/5.16.4/5.17.0) | --- ### Release Notes <details> <summary>testing-library/jest-dom (@&#8203;testing-library/jest-dom)</summary> ### [`v5.17.0`](https://github.com/testing-library/jest-dom/releases/tag/v5.17.0) [Compare Source](testing-library/jest-dom@v5.16.5...v5.17.0) ##### Features - New `toHaveAccessibleErrorMessage` better implementing the spec, deprecate `toHaveErrorMessage` ([#&#8203;503](testing-library/jest-dom#503)) ([d717c66](testing-library/jest-dom@d717c66)) ### [`v5.16.5`](https://github.com/testing-library/jest-dom/releases/tag/v5.16.5) [Compare Source](testing-library/jest-dom@v5.16.4...v5.16.5) ##### Bug Fixes - migrate ccs v3 to [@&#8203;adobe/css-tools](https://github.com/adobe/css-tools) v4 ([#&#8203;470](testing-library/jest-dom#470)) ([948d90f](testing-library/jest-dom@948d90f)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNSIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi41IiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Reviewed-on: https://gitea.bruyant.xyz/alexandre/PaletteSwitcher/pulls/45 Co-authored-by: Renovate <renovate@bruyant.xyz> Co-committed-by: Renovate <renovate@bruyant.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants