Skip to content

Commit d4f9de8

Browse files
bugfoodchrisbra
authored andcommitted
patch 9.1.1938: tests: excessive wait in Test_matchfuzzy_initialized
Problem: tests: excessive wait in Test_matchfuzzy_initialized Solution: Use term_wait() instead of the TermWait() wrapper (Corey Hickey) Test_matchfuzzy_initialized is a terminal test, which are specified to be "flaky" and automatically retried. The TermWait wrapper multiplies the specified wait time by higher values for later retries, maxing out at 10x the specified value. This makes tries #3 to #6 sleep for 20 seconds each, which makes the test very slow to work with. The specified intent of the test (as noted in a comment eight lines above here) is to sleep for 2s. closes: #18822 Signed-off-by: Corey Hickey <bugfood-c@fatooh.org> Signed-off-by: Christian Brabandt <cb@256bit.org>
1 parent a3925d7 commit d4f9de8

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/testdir/test_matchfuzzy.vim

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,9 @@ func Test_matchfuzzy_initialized()
300300

301301
let buf = RunVimInTerminal('-u NONE -X -Z', {})
302302
call term_sendkeys(buf, ":source XTest_matchfuzzy\n")
303-
call TermWait(buf, 2000)
303+
" Use term_wait directly rather than the TermWait wrapper; otherwise,
304+
" retries become very slow.
305+
call term_wait(buf, 2000)
304306

305307
let job = term_getjob(buf)
306308
if job_status(job) == "run"

src/version.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -729,6 +729,8 @@ static char *(features[]) =
729729

730730
static int included_patches[] =
731731
{ /* Add new patch number below this line */
732+
/**/
733+
1938,
732734
/**/
733735
1937,
734736
/**/

0 commit comments

Comments
 (0)