feat(loader): add baseUri option when using loaderContext.importModule #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alexander-akait previously approved these changes Feb 22, 2022
Member
alexander-akait left a comment
alexander-akait left a comment There was a problem hiding this comment.
I will add more test to verify #872 is fixed
vankop force-pushed the fix/webpack-15172 branch from f031cdb to a67ba36 Compare 
vankop force-pushed the fix/webpack-15172 branch 2 times, most recently from e655140 to 46d24f3 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #915 +/- ## ========================================== + Coverage 90.29% 90.33% +0.04% ========================================== Files 5 5 Lines 824 828 +4 Branches 220 221 +1 ========================================== + Hits 744 748 +4 Misses 70 70 Partials 10 10
Continue to review full report at Codecov.
|
vankop force-pushed the fix/webpack-15172 branch from 46d24f3 to ba299b1 Compare 
vankop force-pushed the fix/webpack-15172 branch from ba299b1 to febbb7e Compare alexander-akait approved these changes Mar 3, 2022
|
Was trying out the new version and was getting this error afterwards with |
Member Author
| @rodoabad did you use latest webpack? |
| Yep I did. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
webpack/webpack#15172
Breaking Changes
no
Additional Info
need webpack/webpack#15430 and release webpack